Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up access control capabilities APIs #14455

Closed
mlepage-google opened this issue Jan 27, 2022 · 3 comments · Fixed by #17817
Closed

Clean up access control capabilities APIs #14455

mlepage-google opened this issue Jan 27, 2022 · 3 comments · Fixed by #17817
Assignees
@mlepage-google
Labels
acl Access Control feature V1.0

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Jan 27, 2022 •
edited
Loading

Flesh out the capabilities API.

E.g. probably useful to be able to get number of entries of a given fabric, max possible entries for a given fabric, etc.

This may be affected generally by #14449
@mlepage-google mlepage-google added acl Access Control feature V1.0 labels Jan 27, 2022
@mlepage-google mlepage-google mentioned this issue Jan 27, 2022
Closed
@andy31415 andy31415 added v1_triage_split_7 V1.0 acl Access Control feature and removed V1.0 acl Access Control feature labels Jan 30, 2022
@mlepage-google
Copy link
Contributor Author

Also once this spec change lands, will need to expose some of this info in the cluster.

https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5070

@mlepage-google
Copy link
Contributor Author

Regarding landed spec change
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5070

a cluster change has landed to expose those attributes, in PR #17294

However the assumption (fine for now) is that a particular implementation is used. When these capabilities APIs are available, that cluster attribute implementation needs to use those APIs.

@mlepage-google mlepage-google mentioned this issue Apr 20, 2022
Merged
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Apr 27, 2022
@mlepage-google
Enforce length constraints in access control
3c492c1 
Add some APIs for length constraints. Use them in system module and in
cluster to enforce length constraints.

Partially fixes project-chip#14455
Partially fixes project-chip#14460
Partially fixes project-chip#16034
@mlepage-google mlepage-google mentioned this issue Apr 27, 2022
Merged
@mlepage-google
Copy link
Contributor Author

PR #17817 does most of this but doesn't remove the old APIs. That will come next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce length constraints in access control mlepage-google/connectedhomeip
3 participants
@andy31415 @kpschoedel @mlepage-google