Introduce ACL logging verbosity control #17354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When bringing-up an AccessControl::Delegate, extra policy verbose logging is helpful. However, extra verbose logging is currently always enabled, which takes a lot of logging buffer space when complex transactions (long paths, wildcards) are used, to just emit debug data. - Current method to turn it down is to turn off all progress logging, but progress logging may have a lot of important details. This PR introduces a logging verbosity control for Access Control, using the `chip_access_control_policy_logging_verbosity` build config variable. High verbosity is maintained in linux/Darwin *-app, but turned down by default elsewhere. Issue project-chip#14449 Testing done: - unit tests still pass - integration tests still pass - logs are less on m5stack - logs are fully verbose on linux
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
andy31415
approved these changes
Apr 13, 2022
mlepage-google
approved these changes
Apr 13, 2022
|
PR #17354: Size comparison from 20be070 to 387b626 Increases above 0.2%:
Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 14, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Introduce ACL logging verbosity control - When bringing-up an AccessControl::Delegate, extra policy verbose logging is helpful. However, extra verbose logging is currently always enabled, which takes a lot of logging buffer space when complex transactions (long paths, wildcards) are used, to just emit debug data. - Current method to turn it down is to turn off all progress logging, but progress logging may have a lot of important details. This PR introduces a logging verbosity control for Access Control, using the `chip_access_control_policy_logging_verbosity` build config variable. High verbosity is maintained in linux/Darwin *-app, but turned down by default elsewhere. Issue project-chip#14449 Testing done: - unit tests still pass - integration tests still pass - logs are less on m5stack - logs are fully verbose on linux * Restyled by clang-format * Restyled by gn * Fix CI Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
verbose logging is helpful. However, extra verbose logging
is currently always enabled, which takes a lot of logging buffer
space when complex transactions (long paths, wildcards) are used,
to just emit debug data.
but progress logging may have a lot of important details.
Issue #14449
Change overview
This PR introduces a logging verbosity control for Access Control,
using the
chip_access_control_policy_logging_verbositybuildconfig variable.
High verbosity is maintained in linux/Darwin *-app, but turned
down by default elsewhere.
Testing