Add unit tests for SystemTimer.h #12729
Assignees
Comments
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this issue
Dec 8, 2021
#### Problem Only the higher-level `System::Layer` timer operations had tests; the utility classes in `system/SystemTimer.h` had no unit tests, and a recent refactor (project-chip#12628) introduced a bug that a proper unit test would have caught. Fixes project-chip#12729 Add unit tests for SystemTimer.h #### Change overview What's in this PR - Add tests covering `TimerData`, `TimeList`, and `TimerPool`. - Changed these helpers to take a `Timestamp` rather than a `Timeout`. - Fixed `TimerList::Remove(Node*)` to allow an empty list or null argument (matching its description). #### Testing Quis custodiet ipsos custodes?
andy31415
pushed a commit
that referenced
this issue
Dec 8, 2021
#### Problem Only the higher-level `System::Layer` timer operations had tests; the utility classes in `system/SystemTimer.h` had no unit tests, and a recent refactor (#12628) introduced a bug that a proper unit test would have caught. Fixes #12729 Add unit tests for SystemTimer.h #### Change overview What's in this PR - Add tests covering `TimerData`, `TimeList`, and `TimerPool`. - Changed these helpers to take a `Timestamp` rather than a `Timeout`. - Fixed `TimerList::Remove(Node*)` to allow an empty list or null argument (matching its description). #### Testing Quis custodiet ipsos custodes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Recent refactoring exposed new classes that aren't unit tested (and in fact contained at least one trivial bug #12723).
Proposed Solution
Add unit tests.
The text was updated successfully, but these errors were encountered: