Streamline ObjectPool in System::Timer #12628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem After the unification of the former `system/SystemObject.h` with `support/Pool.h`, there is an opportunity to simplify `System::Timer`. #### Change overview - Clean up use of `ObjectPool`, with a `TimerPool` wrapper. - Fix some #includes formerly indirectly included by `SystemTimer.h` #### Testing CI; no changes to external functionality.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #12628: Size comparison from f350919 to 6178b4b Increases (9 builds for mbed, p6, qpg)
Decreases (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 6, 2021
woody-apple
approved these changes
Dec 6, 2021
|
fast track: change by domain owner, sufficient uptime for all timezone review. |
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Dec 8, 2021
#### Problem Only the higher-level `System::Layer` timer operations had tests; the utility classes in `system/SystemTimer.h` had no unit tests, and a recent refactor (project-chip#12628) introduced a bug that a proper unit test would have caught. Fixes project-chip#12729 Add unit tests for SystemTimer.h #### Change overview What's in this PR - Add tests covering `TimerData`, `TimeList`, and `TimerPool`. - Changed these helpers to take a `Timestamp` rather than a `Timeout`. - Fixed `TimerList::Remove(Node*)` to allow an empty list or null argument (matching its description). #### Testing Quis custodiet ipsos custodes?
andy31415
pushed a commit
that referenced
this pull request
Dec 8, 2021
#### Problem Only the higher-level `System::Layer` timer operations had tests; the utility classes in `system/SystemTimer.h` had no unit tests, and a recent refactor (#12628) introduced a bug that a proper unit test would have caught. Fixes #12729 Add unit tests for SystemTimer.h #### Change overview What's in this PR - Add tests covering `TimerData`, `TimeList`, and `TimerPool`. - Changed these helpers to take a `Timestamp` rather than a `Timeout`. - Fixed `TimerList::Remove(Node*)` to allow an empty list or null argument (matching its description). #### Testing Quis custodiet ipsos custodes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the unification of the former
system/SystemObject.hwith
support/Pool.h, there is an opportunity to simplifySystem::Timer.Change overview
ObjectPool, with aTimerPoolwrapper.SystemTimer.hTesting
CI; no changes to external functionality.