Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timer list empty bug #12723

Closed
wants to merge 1 commit into from
Closed

Fix timer list empty bug #12723

wants to merge 1 commit into from

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Dec 8, 2021 •
edited
Loading

Problem

The TimerList::Empty() returns wrong value.

Change overview

A small bug fix.

@boring-cyborg boring-cyborg bot added the system label Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12723: Size comparison from b9d8ef1 to 011a8a7

Increases (2 builds for esp32, qpg)
platform target config section b9d8ef1 011a8a7 change % change
esp32 all-clusters-app m5stack (read only) 958283 958287 4 0.0
.flash.text 952899 952903 4 0.0
qpg lock-app qpg6100+debug (read only) 485948 485956 8 0.0
.text 480628 480636 8 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b9d8ef1 011a8a7 change % change
efr32 lighting-app BRD4161A (read only) 794704 794704 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794696 794696 0 0.0
BRD4161A+rpc (read only) 782316 782316 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 782308 782308 0 0.0
window-app BRD4161A (read only) 771640 771640 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771632 771632 0 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855576 0 0.0
(read/write) 1305994 1305994 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171192 0 0.0
.flash.text 855576 855576 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958283 958287 4 0.0
(read/write) 450236 450236 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209400 0 0.0
.flash.text 952899 952903 4 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731932 731932 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643040 643040 0 0.0
lock-app k32w061+debug (read/write) 622516 622516 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 542992 542992 0 0.0
shell k32w061+debug (read/write) 685608 685608 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596412 596412 0 0.0
linux all-clusters-app debug (read only) 1903833 1903833 0 0.0
(read/write) 131584 131584 0 0.0
.bss 56688 56688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68240 68240 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155812 155812 0 0.0
.text 1602258 1602258 0 0.0
bridge-app debug+rpc (read only) 1447629 1447629 0 0.0
(read/write) 77712 77712 0 0.0
.bss 39120 39120 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31800 31800 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123580 123580 0 0.0
.text 1218837 1218837 0 0.0
chip-tool debug (read only) 6689749 6689749 0 0.0
(read/write) 202336 202336 0 0.0
.bss 35272 35272 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160360 160360 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335753 335753 0 0.0
.text 5944901 5944901 0 0.0
lighting-app debug+rpc (read only) 1735377 1735377 0 0.0
(read/write) 110776 110776 0 0.0
.bss 44816 44816 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 59312 59312 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144444 144444 0 0.0
.text 1447954 1447954 0 0.0
ota-provider-app debug (read only) 1412041 1412041 0 0.0
(read/write) 75688 75688 0 0.0
.bss 41600 41600 0 0.0
.data 896 896 0 0.0
.data.rel.ro 28008 28008 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124990 124990 0 0.0
.text 1182146 1182146 0 0.0
ota-requestor-app debug (read only) 1516793 1516793 0 0.0
(read/write) 80704 80704 0 0.0
.bss 44768 44768 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29768 29768 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137711 137711 0 0.0
.text 1270274 1270274 0 0.0
shell debug (read only) 828497 828497 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 86226 86226 0 0.0
.text 635170 635170 0 0.0
tv-app debug (read only) 2044049 2044049 0 0.0
(read/write) 324120 324120 0 0.0
.bss 251160 251160 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176572 176572 0 0.0
.text 1712450 1712450 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316008 2316008 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1278584 1278584 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298656 2298656 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1261256 1261256 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271568 2271568 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1234168 1234168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896763 896763 0 0.0
bss 116176 116176 0 0.0
rodata 100132 100132 0 0.0
text 604900 604900 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859803 0 0.0
bss 112524 112524 0 0.0
rodata 91428 91428 0 0.0
text 579628 579628 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822706 0 0.0
bss 117552 117552 0 0.0
rodata 95388 95388 0 0.0
text 535272 535272 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869199 869199 0 0.0
bss 113440 113440 0 0.0
rodata 96248 96248 0 0.0
text 584156 584156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795386 795386 0 0.0
bss 114848 114848 0 0.0
rodata 91540 91540 0 0.0
text 514620 514620 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874099 0 0.0
bss 113352 113352 0 0.0
rodata 97604 97604 0 0.0
text 587672 587672 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867323 0 0.0
bss 113228 113228 0 0.0
rodata 95740 95740 0 0.0
text 582892 582892 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2349776 2349776 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308040 1308040 0 0.0
light-app default (read/write) 2281080 2281080 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239344 1239344 0 0.0
lock-app default (read/write) 2257168 2257168 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215432 1215432 0 0.0
qpg lighting-app qpg6100+debug (read only) 511764 511764 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506444 506444 0 0.0
lock-app qpg6100+debug (read only) 485948 485956 8 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480628 480636 8 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800086 800086 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557192 557192 0 0.0

tcarmelveilleux
tcarmelveilleux approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test that could have found this? This is absolutely in the real of what should have been unit tested

@kpschoedel kpschoedel mentioned this pull request Dec 8, 2021
Closed
@kpschoedel
Copy link
Contributor

Is there a unit test that could have found this? This is absolutely in the real of what should have been unit tested

There isn't because historically that code was an unexposed internal detail. But yes, I should have added some when I refactored it, and will do so. #12729

@wqx6
Copy link
Contributor Author

wqx6 commented Dec 9, 2021

Close since #12742 merged

@wqx6 wqx6 closed this Dec 9, 2021
@kpschoedel
Copy link
Contributor

Close since #12742 merged

Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpschoedel kpschoedel kpschoedel approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - pending system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wqx6 @kpschoedel @tcarmelveilleux @yunhanw-google @Damian-Nordic