Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup: Shouldn't this failure to decode the incoming message send a failure response instead of just silently dropping things on the floor? Similar for other failures in this method. #11724

Closed
yunhanw-google opened this issue Nov 12, 2021 · 1 comment · Fixed by #18706
Closed

Followup: Shouldn't this failure to decode the incoming message send a failure response instead of just silently dropping things on the floor? Similar for other failures in this method. #11724

yunhanw-google opened this issue Nov 12, 2021 · 1 comment · Fixed by #18706
Assignees
@bzbarsky-apple
Labels
Interaction Model Work p2 priority 2 work spec Mismatch between spec and implementation V1.0
Milestone
Test Event 7.5 (d...

Comments

@yunhanw-google
Copy link
Contributor

Followup: Shouldn't this failure to decode the incoming message send a failure response instead of just silently dropping things on the floor? Similar for other failures in this method.

Originally posted by @bzbarsky-apple in #11667 (comment)
@yunhanw-google yunhanw-google mentioned this issue Nov 12, 2021
Merged
@bzbarsky-apple bzbarsky-apple added Interaction Model Work spec Mismatch between spec and implementation labels Nov 12, 2021
@mrjerryjohns mrjerryjohns added the p1 priority 1 work label Nov 19, 2021
@mrjerryjohns mrjerryjohns added p2 priority 2 work TE7.5 and removed p1 priority 1 work labels Nov 19, 2021
@bzbarsky-apple
Copy link
Contributor

The comment there was about InteractionModelEngine::OnReadInitialRequest.

See also #17623

@bzbarsky-apple bzbarsky-apple self-assigned this May 21, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 21, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer.
d9619ea 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes project-chip#11724

Fixes project-chip#17623
@bzbarsky-apple bzbarsky-apple mentioned this issue May 21, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 25, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer.
ec99391 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes project-chip#11724

Fixes project-chip#17623
bzbarsky-apple added a commit that referenced this issue May 25, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer. (#18706)
f18efd8 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes #11724

Fixes #17623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
Interaction Model Work p2 priority 2 work spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
Test Event 7.5 (dev milestone)
Development

Successfully merging a pull request may close this issue.

Make the error-handling in OnReadInitialRequest clearer. bzbarsky-apple/connectedhomeip
6 participants
@andy31415 @mrjerryjohns @harimau-qirex @yunhanw-google @woody-apple @bzbarsky-apple