-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send status report in IM server side when server encounter the error #11667
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/improve_status_response
Nov 17, 2021
Merged
Send status report in IM server side when server encounter the error #11667
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/improve_status_response
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
November 11, 2021 08:23
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 11, 2021 08:23
PR #11667: Size comparison from d45cfaa to 631efe9 Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (2 builds for mbed)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 11, 2021
woody-apple
approved these changes
Nov 11, 2021
yunhanw-google
force-pushed
the
feature/improve_status_response
branch
from
November 11, 2021 18:37
631efe9
to
9bdf8ac
Compare
bzbarsky-apple
requested changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to request changes... See above review for things that need fixing.
PR #11667: Size comparison from a7d17ac to 9bdf8ac Increases (24 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/improve_status_response
branch
from
November 12, 2021 08:18
40cc97c
to
50db0f3
Compare
PR #11667: Size comparison from c7018a7 to 50db0f3 Increases (24 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
When server don't have readhandler/subscribe handler, server would send status report with RESOURCE_EXHAUSTED. When server don't have writehandler/commandhandler, server would send status report with BUSY. For other error geneared when recieving incoming request in server, server would send status report with FAILURE
yunhanw-google
force-pushed
the
feature/improve_status_response
branch
from
November 12, 2021 17:10
50db0f3
to
460ca44
Compare
PR #11667: Size comparison from 5d4bade to 460ca44 Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 16, 2021
yufengwangca
approved these changes
Nov 17, 2021
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 18, 2021
raqbit
pushed a commit
to raqbit/connectedhomeip
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When server don't have readhandler/subscribe handler, server would send
status report with RESOURCE_EXHAUSTED.
When server don't have writehandler/commandhandler, server would send
status report with BUSY.
For other error generated when recieving incoming request in server,
server would send status report with FAILURE
Change overview
See above
Testing
Add unit test to overflow the range for read/subscribe handler pool, then check the error