Make the error-handling in OnReadInitialRequest clearer. #18706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #18706: Size comparison from 55ef609 to d9619ea Increases (5 builds for cc13x2_26x2)
Decreases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 24, 2022
yunhanw-google
approved these changes
May 24, 2022
arkq
approved these changes
May 25, 2022
Instead of having both a status outparam and an error return, just use a status return. Also fixes some bugs where we were not checking the results of some TLV parsing operations, and not converting some TVL parsing failures to the right status. Fixes project-chip#11724 Fixes project-chip#17623
bzbarsky-apple
force-pushed
the
read-initial-request
branch
from
d9619ea to
ec99391
Compare
|
PR #18706: Size comparison from a3fdd05 to ec99391 Increases (5 builds for cc13x2_26x2)
Decreases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having both a status outparam and an error return, just use a status return.
Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.
Fixes #11724
Fixes #17623
Problem
Confusing error handling, missing error checks.
Change overview
Fix that.
Testing
Just makes sure that we can't forget to set our status.