Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermostat cluster attributes that should be nullable are not marked that way in the XML #11670

Closed
ghost opened this issue Nov 11, 2021 · 8 comments · Fixed by #18594
Closed

Thermostat cluster attributes that should be nullable are not marked that way in the XML #11670

ghost opened this issue Nov 11, 2021 · 8 comments · Fixed by #18594
Labels
app-clusters Application cluster work cert spec Mismatch between spec and implementation V1.0

Comments

@ghost
Copy link

ghost commented Nov 11, 2021

Summary:
As per spec the default value of some attributes are null and we need to check the default value as expected using Scripts but Null check is not implemented in YAML framework.

Spec Screenshot:
image

Execution Screenshot:
image
@bzbarsky-apple
Copy link
Contributor

Null checking is implemented just fine. But in the XML these attributes are not marked nullable.

@bzbarsky-apple bzbarsky-apple changed the title "Null" check implementation in YAML framework Thermostat cluster attributes that should be nullable are not marked that way in the XML Jan 7, 2022
@ghost
Copy link
Author

ghost commented Jan 10, 2022

@bzbarsky-apple we are facing same build error issue in Pump configuration cluster:
Spec screenshot:
image
Execution screenshot:
image

@bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple we are facing same build error issue in Pump configuration cluster:

I suggest filing separate issues per cluster that has this problem, but more importantly getting the domain owners for these clusters to fix those issues...

@ghost
Copy link
Author

ghost commented Jan 19, 2022

@bzbarsky-apple we are facing same build error issue in Pump configuration cluster:

I suggest filing separate issues per cluster that has this problem, but more importantly getting the domain owners for these clusters to fix those issues...

ok i will do it

@andy31415 andy31415 added v1_triage_split_1 spec Mismatch between spec and implementation and removed v1_triage_split_1 labels Jan 30, 2022
@ghost
Copy link
Author

ghost commented Mar 23, 2022

#16552

@ghost
Copy link
Author

ghost commented Mar 23, 2022

#16550

@ghost
Copy link
Author

ghost commented Mar 23, 2022

#16554

@manjunath-grl
Copy link
Contributor

This issue was created by me using a account that i had to delete due to access issues, I will continue to follow these issues with my current id.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 19, 2022
@bzbarsky-apple
Align thermostat cluster better with the spec.
f959293 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes project-chip#11670
@bzbarsky-apple bzbarsky-apple mentioned this issue May 19, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 19, 2022
@bzbarsky-apple
Align thermostat cluster better with the spec.
fb27c1e 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes project-chip#11670
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 19, 2022
@bzbarsky-apple
Align thermostat cluster better with the spec.
ba9d5b8 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes project-chip#11670
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 19, 2022
@bzbarsky-apple
Align thermostat cluster better with the spec.
c3a74f2 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes project-chip#11670
bzbarsky-apple added a commit that referenced this issue May 23, 2022
@bzbarsky-apple
Align thermostat cluster better with the spec. (#18594)
b426529 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes #11670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-clusters Application cluster work cert spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align thermostat cluster better with the spec. bzbarsky-apple/connectedhomeip
4 participants
@andy31415 @woody-apple @bzbarsky-apple @manjunath-grl