Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pump configuration cluster attributes that should be nullable are not marked that way in the XML #16550

Closed
ghost opened this issue Mar 23, 2022 · 3 comments · Fixed by #17181
Closed

Pump configuration cluster attributes that should be nullable are not marked that way in the XML #16550

ghost opened this issue Mar 23, 2022 · 3 comments · Fixed by #17181

Comments

@ghost
Copy link

ghost commented Mar 23, 2022

Summary:
As per spec the default value of some attributes are null and we need to check the default value as expected using Scripts but attributes that should be nullable are not marked that way in the XML

Spec screenshot:
image
Execution screenshot:
image
@ghost ghost mentioned this issue Mar 23, 2022
Closed
@ghost
Copy link
Author

ghost commented Apr 5, 2022

@bzbarsky-apple still facing build error
image

@bzbarsky-apple
Copy link
Contributor

@manjunathambiger23 Sure, it's still not marked nullable. Please talk to the pump configuration folks....

@tlykkeberg-grundfos tlykkeberg-grundfos mentioned this issue Apr 7, 2022
Merged
@tlykkeberg-grundfos
Copy link
Contributor

Fixed in #17181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[XML] Correct the PCC cluster xml to reflect the specification Grundfos/connectedhomeip
2 participants
@bzbarsky-apple @tlykkeberg-grundfos