Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align thermostat cluster better with the spec. #18594

Merged
merged 1 commit into from
May 23, 2022
Merged

Align thermostat cluster better with the spec. #18594

merged 1 commit into from
May 23, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Specific changes:

  • Adjust names of attributes to match the spec.
  • Mark the attributes that are supposed to be nullable as nullable.
  • Make the min values be decimal for various attributes, for readability.
  • Add the various setback attributes and EmergencyHeatDelta.
  • Fix incorrect fourth field for SetWeeklySchedule and
    GetWeeklyScheduleResponse.
  • Fix the types for the NumberOfTransitionsForSequence fields in
    SetWeeklySchedule and GetWeeklyScheduleResponse.
  • Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes #11670

Problem

XML does not match spec.

Change overview

Align the two, as much as possible given the state of the spec.

Testing

Examined some of the generated code. The existing CI for thermostat cluster should keep passing, but we should also be able to enable more YAML tests now.

@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18594: Size comparison from 70e259c to f959293

Increases (4 builds for linux, nrfconnect, p6)
platform target config section 70e259c f959293 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078228 9093108 14880 0.2
(read/write) 646209 646785 576 0.1
.data.rel.ro 583944 584488 544 0.1
.got 15016 15048 32 0.2
.rodata 444948 445012 64 0.0
.text 7169076 7182548 13472 0.2
thermostat-no-ble arm64 (read only) 2353036 2353132 96 0.0
.rodata 147244 147292 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181175 24 0.0
rodata 153176 153200 24 0.0
p6 all-clusters-app default (read/write) 2539096 2539120 24 0.0
.text 1497360 1497384 24 0.0
Full report (14 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70e259c f959293 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625570 625570 0 0.0
.app_xip_area 529184 529184 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628542 628542 0 0.0
.app_xip_area 533612 533612 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570998 570998 0 0.0
.app_xip_area 466352 466352 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 683032 683032 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 599088 599088 0 0.0
lock k32w061+release (read/write) 729608 729608 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645272 645272 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078228 9093108 14880 0.2
(read/write) 646209 646785 576 0.1
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583944 584488 544 0.1
.dynamic 560 560 0 0.0
.got 15016 15048 32 0.2
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444948 445012 64 0.0
.text 7169076 7182548 13472 0.2
thermostat-no-ble arm64 (read only) 2353036 2353132 96 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147244 147292 48 0.0
.text 1975808 1975808 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420736 2420736 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383380 1383380 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181175 24 0.0
bss 138380 138380 0 0.0
rodata 153176 153200 24 0.0
text 810720 810720 0 0.0
p6 all-clusters-app default (read/write) 2539096 2539120 24 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497360 1497384 24 0.0
light-app default (read/write) 2425512 2425512 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383776 1383776 0 0.0
lock-app default (read/write) 2436224 2436224 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394488 1394488 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782752 782752 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553478 553478 0 0.0
lighting-app tlsr9518adk80d (read/write) 802844 802844 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570244 570244 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the thermostat-spec-align branch from f959293 to fb27c1e Compare May 19, 2022 05:50
@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18594: Size comparison from 70e259c to fb27c1e

Increases (6 builds for esp32, linux, nrfconnect, p6)
platform target config section 70e259c fb27c1e change % change
esp32 all-clusters-app c3devkit (read/write) 1478218 1478242 24 0.0
.flash.rodata 209960 209984 24 0.0
m5stack (read only) 1056019 1056055 36 0.0
(read/write) 480212 480236 24 0.0
.flash.rodata 240288 240312 24 0.0
.flash.text 1050635 1050671 36 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078228 9093108 14880 0.2
(read/write) 646209 646785 576 0.1
.data.rel.ro 583944 584488 544 0.1
.got 15016 15048 32 0.2
.rodata 444948 445012 64 0.0
.text 7169076 7182548 13472 0.2
thermostat-no-ble arm64 (read only) 2353036 2353132 96 0.0
.rodata 147244 147292 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181175 24 0.0
rodata 153176 153200 24 0.0
p6 all-clusters-app default (read/write) 2539096 2539120 24 0.0
.text 1497360 1497384 24 0.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 70e259c fb27c1e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 625570 625570 0 0.0
.app_xip_area 529184 529184 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628542 628542 0 0.0
.app_xip_area 533612 533612 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570998 570998 0 0.0
.app_xip_area 466352 466352 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917676 917676 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917668 917668 0 0.0
BRD4161A+rpc (read only) 951848 951848 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951840 951840 0 0.0
BRD4161A+rs911x (read only) 791140 791140 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 791132 791132 0 0.0
lock-app BRD4161A+wf200 (read only) 947140 947140 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 947132 947132 0 0.0
window-app BRD4161A (read only) 897796 897796 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897788 897788 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000894 1000894 0 0.0
(read/write) 1478218 1478242 24 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209960 209984 24 0.0
.flash.text 1000894 1000894 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056019 1056055 36 0.0
(read/write) 480212 480236 24 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 240288 240312 24 0.0
.flash.text 1050635 1050671 36 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 683032 683032 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 599088 599088 0 0.0
lock k32w061+release (read/write) 729608 729608 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645272 645272 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9078228 9093108 14880 0.2
(read/write) 646209 646785 576 0.1
.bss 42209 42209 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583944 584488 544 0.1
.dynamic 560 560 0 0.0
.got 15016 15048 32 0.2
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 444948 445012 64 0.0
.text 7169076 7182548 13472 0.2
thermostat-no-ble arm64 (read only) 2353036 2353132 96 0.0
(read/write) 176289 176289 0 0.0
.bss 87585 87585 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147244 147292 48 0.0
.text 1975808 1975808 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420736 2420736 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383380 1383380 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181151 1181175 24 0.0
bss 138380 138380 0 0.0
rodata 153176 153200 24 0.0
text 810720 810720 0 0.0
p6 all-clusters-app default (read/write) 2539096 2539120 24 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497360 1497384 24 0.0
light-app default (read/write) 2425512 2425512 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383776 1383776 0 0.0
lock-app default (read/write) 2436224 2436224 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394488 1394488 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782752 782752 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553478 553478 0 0.0
lighting-app tlsr9518adk80d (read/write) 802844 802844 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570244 570244 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the thermostat-spec-align branch from fb27c1e to ba9d5b8 Compare May 19, 2022 12:53
@bzbarsky-apple
Align thermostat cluster better with the spec.
c3a74f2 
Specific changes:

* Adjust names of attributes to match the spec.
* Mark the attributes that are supposed to be nullable as nullable.
* Make the min values be decimal for various attributes, for readability.
* Add the various setback attributes and EmergencyHeatDelta.
* Fix incorrect fourth field for SetWeeklySchedule and
  GetWeeklyScheduleResponse.
* Fix the types for the NumberOfTransitionsForSequence fields in
  SetWeeklySchedule and GetWeeklyScheduleResponse.
* Fix incorrect type of RelayStatus in GetRelayStatusLogResponse.

CHIP-Specifications/connectedhomeip-spec#5238
tracks the outstanding spec issue about the fields of the
ThermostatScheduleTransition struct.

Fixes project-chip#11670
@bzbarsky-apple bzbarsky-apple force-pushed the thermostat-spec-align branch from ba9d5b8 to c3a74f2 Compare May 19, 2022 13:27
tehampson
tehampson approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@tehampson tehampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding is correct the only files to review are:

  • src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml
  • src/controller/python/chip/clusters/CHIPClusters.py
  • src/controller/python/chip/clusters/Objects.py

Reading it along side the spec everything LGTM. But I am still pretty green

@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

PR #18594: Size comparison from 329389d to c3a74f2

Increases above 0.2%:

platform target config section 329389d c3a74f2 change % change
linux chip-tool debug .text 7499605 7515381 15776 0.2
tv-casting-app debug (read only) 5417625 5435233 17608 0.3
(read/write) 225024 225536 512 0.2
.data.rel.ro 138080 138592 512 0.4
.text 4718354 4734130 15776 0.3
Increases (12 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6)
platform target config section 329389d c3a74f2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667263 667287 24 0.0
.rodata 100087 100111 24 0.0
shell LP_CC2652R7 (read only) 660330 660354 24 0.0
.rodata 97042 97066 24 0.0
esp32 all-clusters-app c3devkit (read/write) 1477898 1477922 24 0.0
.flash.rodata 209640 209664 24 0.0
m5stack (read only) 1056055 1056091 36 0.0
(read/write) 479884 479908 24 0.0
.flash.rodata 239960 239984 24 0.0
.flash.text 1050671 1050707 36 0.0
linux all-clusters-app debug (read only) 2752073 2752185 112 0.0
.rodata 240925 240989 64 0.0
chip-tool debug (read only) 9309445 9327053 17608 0.2
(read/write) 580088 580600 512 0.1
.data.rel.ro 548696 549208 512 0.1
.rodata 480797 481405 608 0.1
.text 7499605 7515381 15776 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9080980 9095892 14912 0.2
(read/write) 646225 646801 576 0.1
.data.rel.ro 583944 584488 544 0.1
.got 15016 15048 32 0.2
.rodata 445620 445700 80 0.0
.text 7171156 7184644 13488 0.2
shell debug (read only) 2567897 2568009 112 0.0
.rodata 221970 222034 64 0.0
thermostat-no-ble arm64 (read only) 2354428 2354524 96 0.0
.rodata 147356 147404 48 0.0
tv-casting-app debug (read only) 5417625 5435233 17608 0.3
(read/write) 225024 225536 512 0.2
.data.rel.ro 138080 138592 512 0.4
.rodata 339873 340481 608 0.2
.text 4718354 4734130 15776 0.3
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180823 1180847 24 0.0
rodata 152848 152872 24 0.0
p6 all-clusters-app default (read/write) 2538856 2538880 24 0.0
.text 1497120 1497144 24 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 329389d c3a74f2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183408 183384 -24 -0.0
shell LP_CC2652R7 (read/write) 185900 185876 -24 -0.0
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 329389d c3a74f2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667263 667287 24 0.0
(read/write) 183408 183384 -24 -0.0
.bss 73652 73652 0 0.0
.data 3404 3404 0 0.0
.rodata 100087 100111 24 0.0
.text 566948 566948 0 0.0
lock-ftd LP_CC2652R7 (read only) 677339 677339 0 0.0
(read/write) 165316 165316 0 0.0
.bss 72692 72692 0 0.0
.data 3236 3236 0 0.0
.rodata 94907 94907 0 0.0
.text 581948 581948 0 0.0
lock-mtd LP_CC2652R7 (read only) 626163 626163 0 0.0
(read/write) 145524 145524 0 0.0
.bss 68428 68428 0 0.0
.data 3236 3236 0 0.0
.rodata 94795 94795 0 0.0
.text 530876 530876 0 0.0
pump-app LP_CC2652R7 (read only) 659567 659567 0 0.0
(read/write) 184368 184368 0 0.0
.bss 72948 72948 0 0.0
.data 3268 3268 0 0.0
.rodata 79415 79415 0 0.0
.text 579672 579672 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654079 654079 0 0.0
(read/write) 189664 189664 0 0.0
.bss 73012 73012 0 0.0
.data 3232 3232 0 0.0
.rodata 83527 83527 0 0.0
.text 570072 570072 0 0.0
shell LP_CC2652R7 (read only) 660330 660354 24 0.0
(read/write) 185900 185876 -24 -0.0
.bss 76012 76012 0 0.0
.data 3408 3408 0 0.0
.rodata 97042 97066 24 0.0
.text 563064 563064 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 625386 625386 0 0.0
.app_xip_area 529000 529000 0 0.0
.bss 79028 79028 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 628342 628342 0 0.0
.app_xip_area 533412 533412 0 0.0
.bss 77604 77604 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570990 570990 0 0.0
.app_xip_area 466344 466344 0 0.0
.bss 87024 87024 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917492 917492 0 0.0
(read/write) 133244 133244 0 0.0
.bss 131184 131184 0 0.0
.data 2060 2060 0 0.0
.text 917484 917484 0 0.0
BRD4161A+rpc (read only) 951664 951664 0 0.0
(read/write) 149928 149928 0 0.0
.bss 147664 147664 0 0.0
.data 2264 2264 0 0.0
.text 951656 951656 0 0.0
BRD4161A+rs911x (read only) 791020 791020 0 0.0
(read/write) 129512 129512 0 0.0
.bss 127444 127444 0 0.0
.data 2068 2068 0 0.0
.text 791012 791012 0 0.0
lock-app BRD4161A+wf200 (read only) 946996 946996 0 0.0
(read/write) 123996 123996 0 0.0
.bss 121972 121972 0 0.0
.data 2024 2024 0 0.0
.text 946988 946988 0 0.0
window-app BRD4161A (read only) 897604 897604 0 0.0
(read/write) 133304 133304 0 0.0
.bss 131256 131256 0 0.0
.data 2048 2048 0 0.0
.text 897596 897596 0 0.0
esp32 all-clusters-app c3devkit (read only) 1000960 1000960 0 0.0
(read/write) 1477898 1477922 24 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 209640 209664 24 0.0
.flash.text 1000960 1000960 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1056055 1056091 36 0.0
(read/write) 479884 479908 24 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 239960 239984 24 0.0
.flash.text 1050671 1050707 36 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 682864 682864 0 0.0
.bss 80224 80224 0 0.0
.data 2016 2016 0 0.0
.text 598920 598920 0 0.0
lock k32w061+release (read/write) 729408 729408 0 0.0
.bss 80656 80656 0 0.0
.data 1976 1976 0 0.0
.text 645072 645072 0 0.0
linux all-clusters-app debug (read only) 2752073 2752185 112 0.0
(read/write) 175904 175904 0 0.0
.bss 85056 85056 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82632 82632 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 240925 240989 64 0.0
.text 2336834 2336834 0 0.0
bridge-app debug+rpc (read only) 2034657 2034657 0 0.0
(read/write) 147736 147736 0 0.0
.bss 72864 72864 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65368 65368 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169225 169225 0 0.0
.text 1708386 1708386 0 0.0
chip-tool debug (read only) 9309445 9327053 17608 0.2
(read/write) 580088 580600 512 0.1
.bss 23936 23936 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 548696 549208 512 0.1
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 480797 481405 608 0.1
.text 7499605 7515381 15776 0.2
chip-tool-no-interactive-ipv6only arm64 (read only) 9080980 9095892 14912 0.2
(read/write) 646225 646801 576 0.1
.bss 42225 42225 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 583944 584488 544 0.1
.dynamic 560 560 0 0.0
.got 15016 15048 32 0.2
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 445620 445700 80 0.0
.text 7171156 7184644 13488 0.2
lighting-app debug+rpc (read only) 2329169 2329169 0 0.0
(read/write) 153184 153184 0 0.0
.bss 74656 74656 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70712 70712 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188265 188265 0 0.0
.text 1974626 1974626 0 0.0
lock-app debug (read only) 2242665 2242665 0 0.0
(read/write) 147896 147896 0 0.0
.bss 73344 73344 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 198905 198905 0 0.0
.text 1883874 1883874 0 0.0
ota-provider-app debug (read only) 2064593 2064593 0 0.0
(read/write) 140944 140944 0 0.0
.bss 72800 72800 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60584 60584 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179456 179456 0 0.0
.text 1726642 1726642 0 0.0
ota-requestor-app debug (read only) 2093545 2093545 0 0.0
(read/write) 143752 143752 0 0.0
.bss 73472 73472 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62648 62648 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175488 175488 0 0.0
.text 1758098 1758098 0 0.0
shell debug (read only) 2567897 2568009 112 0.0
(read/write) 199768 199768 0 0.0
.bss 115752 115752 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76896 76896 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 221970 222034 64 0.0
.text 2184994 2184994 0 0.0
thermostat-no-ble arm64 (read only) 2354428 2354524 96 0.0
(read/write) 176305 176305 0 0.0
.bss 87601 87601 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79376 79376 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147356 147404 48 0.0
.text 1978160 1978160 0 0.0
tv-app debug (read only) 2854657 2854657 0 0.0
(read/write) 278752 278752 0 0.0
.bss 190744 190744 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 77088 77088 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221329 221329 0 0.0
.text 2451202 2451202 0 0.0
tv-casting-app debug (read only) 5417625 5435233 17608 0.3
(read/write) 225024 225536 512 0.2
.bss 78360 78360 0 0.0
.data 2368 2368 0 0.0
.data.rel.ro 138080 138592 512 0.4
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339873 340481 608 0.2
.text 4718354 4734130 15776 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420600 2420600 0 0.0
.bss 202668 202668 0 0.0
.data 5872 5872 0 0.0
.text 1383244 1383244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180823 1180847 24 0.0
bss 138380 138380 0 0.0
rodata 152848 152872 24 0.0
text 810732 810732 0 0.0
p6 all-clusters-app default (read/write) 2538856 2538880 24 0.0
.bss 136176 136176 0 0.0
.data 2808 2808 0 0.0
.text 1497120 1497144 24 0.0
light-app default (read/write) 2425392 2425392 0 0.0
.bss 129488 129488 0 0.0
.data 2608 2608 0 0.0
.text 1383656 1383656 0 0.0
lock-app default (read/write) 2436096 2436096 0 0.0
.bss 129304 129304 0 0.0
.data 2568 2568 0 0.0
.text 1394360 1394360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 782604 782604 0 0.0
bss 70608 70608 0 0.0
noinit 40416 40416 0 0.0
text 553498 553498 0 0.0
lighting-app tlsr9518adk80d (read/write) 802676 802676 0 0.0
bss 70864 70864 0 0.0
noinit 40416 40416 0 0.0
text 570264 570264 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

If my understanding is correct the only files to review are:

The file to review is the .xml along with the spec, but the .matter files can be helpful in reviewing.

The .py files you list are auto-generated, so don't really need to be reviewed.

@bzbarsky-apple
Copy link
Contributor Author

Oh, and the other files with manual changes here were the .yaml test files.

@bzbarsky-apple bzbarsky-apple merged commit b426529 into project-chip:master May 23, 2022
@bzbarsky-apple bzbarsky-apple deleted the thermostat-spec-align branch May 23, 2022 15:34
@hasty hasty mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tehampson tehampson Awaiting requested review from tehampson

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thermostat cluster attributes that should be nullable are not marked that way in the XML
5 participants
@bzbarsky-apple @andy31415 @tehampson @Damian-Nordic @jmeg-sfy