[FIX] Fill the sequence flow conditional start marker #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
bug
Sequence flow conditional marker with custom colors
Message flow start and end markers with custom colorsNote: filling the end markers will prevent change if we decide to stop forcing orthogonal edge segments (see #295 and #351 (comment))
Fixed sequence flow conditional marker
As described in #991
With this PR |
|
♻️ PR Preview 70c305b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 70c305b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
This avoids seeing the sequence flow line over the marker at some zoom level. Implementation notes: - it requires custom code as mxgraph doesn't support filling the markers out of the box. - it is also applied to message flow markers without functional changes to prepare future changes (currently use transparent colors). - it is possible to change all marker fill colors as for other defaults.
tbouffard
force-pushed
the
fix/991-fill_conditional-flow_marker
branch
from
166e5ef to
3796afb
Compare
tbouffard
changed the title
csouchet
approved these changes
Jun 15, 2021
|
Kudos, SonarCloud Quality Gate passed! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids seeing the sequence flow line over the marker at some zoom level.
Implementation notes:
- it requires custom code as mxgraph doesn't support filling the markers out
of the box.
- it is also applied to message flow markers without functional changes to
prepare future changes (currently use transparent colors).
- it is possible to change all marker fill colors as for other defaults.
closes #991
covers #995