Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Review the message flow start marker #995

Closed
tbouffard opened this issue Dec 29, 2020 · 0 comments · Fixed by #1367
Closed

[FEAT] Review the message flow start marker #995

tbouffard opened this issue Dec 29, 2020 · 0 comments · Fixed by #1367
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Dec 29, 2020

The size of the marker may be reviewed (larger?) and the filled color as well.
It is currently transparent so we see the background shape stroke and the flow segment traversing the marker. Having a filled color may probably better highlight the marker.

Proposal with a filled ellipse

See the marker of the top left and bottom right flows.
This has been evoked when implementing the 1st message flow rendering, let's review this now: #394 (comment) and related discussions.

filled ellipse

Additional context

The current style configuration explicitly set no fill color.

      FlowKind.MESSAGE_FLOW,
      (style: StyleMap) => {
        style[mxConstants.STYLE_DASHED] = true;
        style[mxConstants.STYLE_DASH_PATTERN] = '8 5';
        style[mxConstants.STYLE_STARTARROW] = mxConstants.ARROW_OVAL;
        style[mxConstants.STYLE_STARTSIZE] = 8;
        style[mxConstants.STYLE_STARTFILL] = false;
        style[mxConstants.STYLE_ENDARROW] = mxConstants.ARROW_BLOCK_THIN;
        style[mxConstants.STYLE_ENDFILL] = false;
      },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant