Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Render Message Flow with no message #394

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jul 6, 2020

Closes #389

image

The position of the edge will be fixed with #351 and/or #349

@csouchet csouchet added enhancement New feature or request depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first BPMN rendering Something about the way the lib is rendering BPMN elements labels Jul 6, 2020
@csouchet csouchet marked this pull request as ready for review July 6, 2020 16:17
@csouchet csouchet force-pushed the 389-Render_Message_Flow_with_no_message branch from 35bc0a0 to da181de Compare July 7, 2020 15:34
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jul 7, 2020
@csouchet csouchet requested review from tbouffard and aibcmars July 7, 2020 15:35
@tbouffard
Copy link
Member

tbouffard commented Jul 8, 2020

@csouchet on the current screenshot, it seems that there is a transparency, z-order or fill color issue with the message flow start marker. We see the attached start shape on top of the circle i.e. a line crosses the circle.
I have seen this with the conditional sequence flow marker when zooming, but this doesn't occur often.

Start shape current may be expected
Activity image image
Pool image image
Event image image

@csouchet
Copy link
Member Author

csouchet commented Jul 8, 2020

@csouchet on the current screenshot, it seems that there is a transparency, z-order or fill color issue with the message flow start marker. We see the attached start shape on top of the circle i.e. a line crosses the circle.
I have seen this with the conditional sequence flow marker when zooming, but this doesn't occur often.

Let's talk directly. I'm not sure that I understand what you say 😉

@csouchet
Copy link
Member Author

csouchet commented Jul 8, 2020

@csouchet on the current screenshot, it seems that there is a transparency, z-order or fill color issue with the message flow start marker. We see the attached start shape on top of the circle i.e. a line crosses the circle.
I have seen this with the conditional sequence flow marker when zooming, but this doesn't occur often.
Start shape current may be expected
Activity image image
Pool image image
Event image image

If you see the BPMN specification, there is no obligation to have a filled circle:
image

I searched in the mxGraph's configuration, but we can't filled the STYLE_STARTARROW with a different color than that used for the stroke.

If we really want it, we need to create our own marker, like the Dash marker.

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
As discussed with @csouchet about the circle start marker (see #394 (comment)), we keep as it and may change it later if needed.

@tbouffard tbouffard merged commit 444c60a into master Jul 8, 2020
@tbouffard tbouffard deleted the 389-Render_Message_Flow_with_no_message branch July 8, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Message Flow with no message
3 participants