-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Render Message Flow with no message #394
Conversation
35bc0a0
to
da181de
Compare
@csouchet on the current screenshot, it seems that there is a transparency, z-order or fill color issue with the message flow start marker. We see the attached start shape on top of the circle i.e. a line crosses the circle.
|
Let's talk directly. I'm not sure that I understand what you say 😉 |
If you see the BPMN specification, there is no obligation to have a filled circle: I searched in the mxGraph's configuration, but we can't filled the STYLE_STARTARROW with a different color than that used for the stroke. If we really want it, we need to create our own marker, like the Dash marker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
As discussed with @csouchet about the circle start marker (see #394 (comment)), we keep as it and may change it later if needed.
Closes #389
The position of the edge will be fixed with #351 and/or #349