Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Conditional sequence flow marker sometimes overlapped by the edge line #991

Closed
tbouffard opened this issue Dec 29, 2020 · 1 comment · Fixed by #1366
Closed

[BUG] Conditional sequence flow marker sometimes overlapped by the edge line #991

tbouffard opened this issue Dec 29, 2020 · 1 comment · Fixed by #1366
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working mxgraph integration Something involving mxGraph (be aware of EOL)
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Dec 29, 2020

Describe the bug
Seen in [email protected] but existed before.
When zooming on the flows.sequence.kinds.and.complex.paths.bpmn non regression diagram, depending on the scale, the line overlaps the diamond.

conditional_flow_diamond_glitch_contains_line

This issue is always visible with the adonis-np-8_0-miwg-A.2.1-export.bpmn (from miwg-test-suite, also available in the xml-parsing test diagrams folder)

adonis-np-8_0-miwg-A.2.1-export.bpmn

To Reproduce
This issue is reproducible at least on Windows and Ubuntu, with Firefox and Chrome, and seems related to the mxgraph integration (see below).

Additional context

Notes:

As a workaround, we may fill the the diamond with the default fill color (white) as it is also suggested for message flow start marker (#995). The current style configuration explicitly set no fill color

      SequenceFlowKind.CONDITIONAL_FROM_ACTIVITY,
      (style: StyleMap) => {
        style[mxConstants.STYLE_STARTARROW] = mxConstants.ARROW_DIAMOND_THIN;
        style[mxConstants.STYLE_STARTSIZE] = 18;
        style[mxConstants.STYLE_STARTFILL] = false;
      },

Notice that we should 1st try to understand if this is a scaling computation issue, as it may impact other part of the BPMN rendering.

@tbouffard tbouffard added bug Something isn't working BPMN rendering Something about the way the lib is rendering BPMN elements mxgraph integration Something involving mxGraph (be aware of EOL) labels Dec 29, 2020
@tbouffard tbouffard added this to the BPMN rendering improvements milestone Dec 29, 2020
@tbouffard
Copy link
Member Author

tbouffard commented Apr 16, 2021

This may be the same root cause as #994. See #994 (comment)
--> confirmed that this is the root cause (scaling issue, some points are removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working mxgraph integration Something involving mxGraph (be aware of EOL)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant