feat: Add no_title support (and stories) for RelativeTime
#2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be53b7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
smockle
commented
May 30, 2024
previews/primer/beta/relative_time_preview/link_with_tooltip.html.erb
Outdated
Show resolved
Hide resolved
…on the attribute being named 'title'
|
Keeping this in draft until the version of github/relative-time-element is bumped. Update: Opened #2882 to pull in the new version! |
joelhawksley
reviewed
Jun 3, 2024
8 tasks
Co-authored-by: Joel Hawksley <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>
…4.1 (#2882) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lindsey Wild <[email protected]> Co-authored-by: lindseywild <[email protected]> Co-authored-by: Jon Rohan <[email protected]> Co-authored-by: primer-css <[email protected]>
joelhawksley
approved these changes
Jun 3, 2024
Co-authored-by: Joel Hawksley <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>
|
Release / npm / Canary (push) failed; sounds like a temporary issue: I’ll re-run the failed check. |
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This is the Primer View Components version of primer/react#4635.
List the issues that this change affects.
Closes https://github.com/github/accessibility-audits/issues/5524
Risk Assessment
This API was deliberately chosen to avoid breaking any existing
RelativeTimeusage that might be relying on thetitleattribute.What approach did you choose and why?
First, this PR updates the version of the
@github/relative-time-elementcustom element fromv4.4.0tov4.4.1, which includesno-title(via github/relative-time-element#283 and github/relative-time-element#284).Second, this PR adds
no_titlesupport to the Primer ViewComponentsRelativeTimecomponent.Third, this PR adds Lookbook stories to demonstrate the effects of
no_title:titleattribute, so nothing happens on hover.Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.