Adds flag to optionally hide title attribute #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
reviewed
May 29, 2024
keithamus
reviewed
May 29, 2024
smockle
reviewed
May 29, 2024
src/relative-time-element.ts
Outdated
Comment on lines
386
to
388
| get noTitle(): boolean { | ||
| return this.hasAttribute('no-title') && this.getAttribute('no-title') === 'true' | ||
| } |
There was a problem hiding this comment.
Non-blocking:
- Is there any reason to make this private?
- Is there any reason to add a setter (to support e.g.
relativeTime.noTitle = false)?
(I can’t think of any good reasons.)
smockle
approved these changes
May 29, 2024
keithamus
reviewed
May 29, 2024
keithamus
reviewed
May 29, 2024
src/relative-time-element.ts
Outdated
| } | ||
|
|
||
| set noTitle(value: boolean | null) { | ||
| this.setAttribute('no-title', value?.toString() || '') |
There was a problem hiding this comment.
This should probably use toggleAttribute which will be a bit simpler.
There was a problem hiding this comment.
I had to pass in a param into the setter even though it's unused... Not sure how else to get around that as I believe it's required 🤔 Maybe it's ok?
smockle
reviewed
May 30, 2024
Co-authored-by: Clay Miller <[email protected]>
8 tasks
andrewpollock
referenced
this pull request
in google/osv.dev
Jun 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | | | | | | [@github/relative-time-element](https://togithub.com/github/relative-time-element) | dependencies | patch | [`4.4.0` -> `4.4.2`](https://renovatebot.com/diffs/npm/@github%2frelative-time-element/4.4.0/4.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sass](https://togithub.com/sass/dart-sass) | devDependencies | patch | [`1.77.0` -> `1.77.5`](https://renovatebot.com/diffs/npm/sass/1.77.0/1.77.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [webpack](https://togithub.com/webpack/webpack) | devDependencies | minor | [`5.91.0` -> `5.92.0`](https://renovatebot.com/diffs/npm/webpack/5.91.0/5.92.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>github/relative-time-element (@​github/relative-time-element)</summary> ### [`v4.4.2`](https://togithub.com/github/relative-time-element/releases/tag/v4.4.2) [Compare Source](https://togithub.com/github/relative-time-element/compare/v4.4.1...v4.4.2) #### What's Changed - Correctly count month durations relative to the end of longer months by [@​lilyinstarlight](https://togithub.com/lilyinstarlight) in [https://github.com/github/relative-time-element/pull/285](https://togithub.com/github/relative-time-element/pull/285) #### New Contributors - [@​lilyinstarlight](https://togithub.com/lilyinstarlight) made their first contribution in [https://github.com/github/relative-time-element/pull/285](https://togithub.com/github/relative-time-element/pull/285) **Full Changelog**: github/relative-time-element@v4.4.1...v4.4.2 ### [`v4.4.1`](https://togithub.com/github/relative-time-element/releases/tag/v4.4.1) [Compare Source](https://togithub.com/github/relative-time-element/compare/v4.4.0...v4.4.1) #### What's Changed - fix: remove dollar sign from command by [@​o-az](https://togithub.com/o-az) in [https://github.com/github/relative-time-element/pull/282](https://togithub.com/github/relative-time-element/pull/282) - Adds flag to optionally hide title attribute by [@​lindseywild](https://togithub.com/lindseywild) in [https://github.com/github/relative-time-element/pull/283](https://togithub.com/github/relative-time-element/pull/283) - fix: Move `noTitle` conditional. by [@​smockle](https://togithub.com/smockle) in [https://github.com/github/relative-time-element/pull/284](https://togithub.com/github/relative-time-element/pull/284) #### New Contributors - [@​o-az](https://togithub.com/o-az) made their first contribution in [https://github.com/github/relative-time-element/pull/282](https://togithub.com/github/relative-time-element/pull/282) - [@​lindseywild](https://togithub.com/lindseywild) made their first contribution in [https://github.com/github/relative-time-element/pull/283](https://togithub.com/github/relative-time-element/pull/283) - [@​smockle](https://togithub.com/smockle) made their first contribution in [https://github.com/github/relative-time-element/pull/284](https://togithub.com/github/relative-time-element/pull/284) **Full Changelog**: github/relative-time-element@v4.4.0...v4.4.1 </details> <details> <summary>sass/dart-sass (sass)</summary> ### [`v1.77.5`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1775) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.4...1.77.5) - Fully trim redundant selectors generated by `@extend`. ### [`v1.77.4`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1774) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.3...1.77.4) ##### Embedded Sass - Support passing `Version` input for `fatalDeprecations` as string over embedded protocol. - Fix a bug in the JS Embedded Host where `Version` could be incorrectly accepted as input for `silenceDeprecations` and `futureDeprecations` in pure JS. ### [`v1.77.3`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1773) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.2...1.77.3) ##### Dart API - `Deprecation.duplicateVariableFlags` has been deprecated and replaced with `Deprecation.duplicateVarFlags` to make it consistent with the `duplicate-var-flags` name used on the command line and in the JS API. ### [`v1.77.2`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1772) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.1...1.77.2) - Don't emit deprecation warnings for functions and mixins beginning with `__`. - Allow user-defined functions whose names begin with `_` and otherwise look like vendor-prefixed functions with special CSS syntax. ##### Command-Line Interface - Properly handle the `--silence-deprecation` flag. - Handle the `--fatal-deprecation` and `--future-deprecation` flags for `--interactive` mode. ### [`v1.77.1`](https://togithub.com/sass/dart-sass/blob/HEAD/CHANGELOG.md#1771) [Compare Source](https://togithub.com/sass/dart-sass/compare/1.77.0...1.77.1) - Fix a crash that could come up with importers in certain contexts. </details> <details> <summary>webpack/webpack (webpack)</summary> ### [`v5.92.0`](https://togithub.com/webpack/webpack/compare/v5.91.0...34e2561addb0f65a7a6fb0ce7ae1aea4cd1d599f) [Compare Source](https://togithub.com/webpack/webpack/compare/v5.91.0...v5.92.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/github/accessibility-audits/issues/5633 & https://github.com/github/accessibility-audits/issues/5524.
Adds a flag to optionally hide the inaccessible
titleattribute. We will use this in the Primer components so we can add an accessible Tooltip element instead for interactive elements.