Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update 'github/relative-time-element' package from 4.4.0 to 4.4.1 #2882

Merged

Conversation

smockle
Copy link
Member

@smockle smockle commented Jun 3, 2024

What are you trying to accomplish?

This PR updates @github/relative-time-element from v4.4.0 to v4.4.1. That adds support for no-title, which unblocks #2872.

List the issues that this change affects.

Unblocks #2872

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

What approach did you choose and why?

I ran npm update @github/relative-time-element. Notably, that command only modified package-lock.json—the version range specified in package.json remains ^4.0.0.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

primer bot and others added 10 commits May 31, 2024 16:54
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@smockle smockle requested a review from a team as a code owner June 3, 2024 18:15
@smockle smockle requested a review from owenniblock June 3, 2024 18:15
Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: 78da5f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smockle
Copy link
Member Author

smockle commented Jun 3, 2024

Hmm.

Failure:
PrimerBetaRelativeTimeTest#test_component_matches_web_component_definition [test/components/primer/beta/relative_time_test.rb:10]:
Missing params on component.
Expected [:no_title] to be empty.

I’ll try merging this into smockle/once-upon-a-relative-time.

@smockle smockle changed the base branch from main to smockle/once-upon-a-relative-time June 3, 2024 18:40
@smockle smockle requested a review from a team as a code owner June 3, 2024 18:40
@smockle smockle requested a review from tbenning June 3, 2024 18:40
@smockle smockle merged commit a7b6026 into smockle/once-upon-a-relative-time Jun 3, 2024
1 of 2 checks passed
@smockle smockle deleted the smockle/update-relative-time-element branch June 3, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants