Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: PT filterInput not work #5568

Closed
kl-nevermore opened this issue Dec 11, 2023 · 1 comment · Fixed by #5571
Closed

MultiSelect: PT filterInput not work #5568

kl-nevermore opened this issue Dec 11, 2023 · 1 comment · Fixed by #5571
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation Component: Tailwind Tailwind specific issue
Milestone

Comments

@kl-nevermore
Copy link
Contributor

Describe the bug

image

props.pt not override
If using props.pt instead, there may be a conflict with data-pc-section. Should MultiSelectBase.js be updated to include p-multiselect-filter-input?

Reproducer

https://codesandbox.io/s/primereact-demo-forked-qrq3mw?file=/src/App.jsx:514-525

PrimeReact version

latest

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@kl-nevermore kl-nevermore added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2023
@melloware melloware self-assigned this Dec 11, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 11, 2023
@melloware
Copy link
Member

The docs are wrong I will fix. Here is your fixed sandbox:
https://codesandbox.io/s/primereact-demo-forked-hr3zr8?file=/src/App.jsx

 <MultiSelect
        pt={{
          filterInput: {
            root: {
              className: "hi-className"
            }
          }
        }}
        value={selectedCities}
        onChange={(e) => setSelectedCities(e.value)}
        options={cities}
        optionLabel="name"
        filter
        placeholder="Select Cities"
        maxSelectedLabels={3}
        className="w-full md:w-20rem"
      />

@melloware melloware added the Component: Documentation Issue or pull request is related to Documentation label Dec 11, 2023
melloware added a commit to melloware/primereact that referenced this issue Dec 11, 2023
melloware added a commit that referenced this issue Dec 11, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
melloware added a commit that referenced this issue Jan 9, 2024
* Fix #5485: Messages restore close animation

* Fix #5490: useDebounce fixed

* Fix #5492: Listbox passthrough fixes

* Fix #5493: Multiselect passthrough fixes

* Fix #5485: Messages restore close animation

* Fix #5499: Autocomplete/Chips PT fixes

* Fix #5479: CascadeSelect PT fixes

* Fix #5509: Button loadingIcon Tailwind fix

* Fix #5512: Dropdown add tabindex for Tailwind

* Support roundingMode for InputNumber

* Fix #5523: BlockUI return activeElement focus

* Fix #5530: Chip onRemove event pass value

* DataTable:converted to data- lookups instead of className lookups

* Fix #5543: OverlayPanel Tailwind close icon

* Fix #5546: prop type error in console

* Fix #5555: BodyCell frozen issue

* Fix #5561: Inplace respect active prop

* Fix #5568: MultiSelect filterInput PT

* Fix #5572: Multselect selectAllLabel was being added to DOM

* Tooltip fix Tailwind CSS

* Dialog Breakpoints

* Calendar disabled date handling

* Fix #5609: ToggleButton focusedState

* Fix #5610: Radio/Checkbox always fire onClick

* fix: #5613, TreeSelect: TreeSelect component is not supporting tooltips and is an issue in multiple select mode

* Fix #5623 - Otherprops not working for InputSwitch

* fix:Calendar not showing correctly in Table

* fix:Image preview zoom in bug

* Fix #5637: Sidebar aria-label close

* Accept array as PT value

* Datatable breakpoints

* fix:ConfirmDialog: acceptButton's pt don't respect button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Component: Tailwind Tailwind specific issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants