Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockUI lost focus #5523

Closed
tampham1210 opened this issue Dec 5, 2023 · 0 comments · Fixed by #5527
Closed

BlockUI lost focus #5523

tampham1210 opened this issue Dec 5, 2023 · 0 comments · Fixed by #5527
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.0

Comments

@tampham1210
Copy link

tampham1210 commented Dec 5, 2023 •
edited
Loading

Describe the bug

After showing loading using BlockUI, the form lost focus.
Expectation: focus again on the previously focused item

As sample below, the button did not focus again after BlockUI closed

Reproducer

primereact/components/lib/blockui/BlockUI.js

Line 41 in d495c08

document.activeElement.blur();

https://codesandbox.io/p/sandbox/primereact-demo-tfwfhc?file=%2Fsrc%2Findex.js

PrimeReact version

9.2.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response
@tampham1210 tampham1210 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 5, 2023
@melloware melloware self-assigned this Dec 5, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 5, 2023
melloware added a commit to melloware/primereact that referenced this issue Dec 5, 2023
@melloware
Fix primefaces#5523: BlockUI return activeElement focus
c173a74
@melloware melloware mentioned this issue Dec 5, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Dec 5, 2023
@melloware
Fix primefaces#5523: BlockUI return activeElement focus
40862b4
melloware added a commit to melloware/primereact that referenced this issue Dec 5, 2023
@melloware
Fix primefaces#5523: BlockUI return activeElement focus
55ebf95
melloware added a commit that referenced this issue Dec 5, 2023
@melloware
Fix #5523: BlockUI return activeElement focus (#5527)
39c187e
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5523: BlockUI return activeElement focus
26de1a6
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes5 (#5713)
98c5b0d 
* Fix #5485: Messages restore close animation

* Fix #5490: useDebounce fixed

* Fix #5492: Listbox passthrough fixes

* Fix #5493: Multiselect passthrough fixes

* Fix #5485: Messages restore close animation

* Fix #5499: Autocomplete/Chips PT fixes

* Fix #5479: CascadeSelect PT fixes

* Fix #5509: Button loadingIcon Tailwind fix

* Fix #5512: Dropdown add tabindex for Tailwind

* Support roundingMode for InputNumber

* Fix #5523: BlockUI return activeElement focus

* Fix #5530: Chip onRemove event pass value

* DataTable:converted to data- lookups instead of className lookups

* Fix #5543: OverlayPanel Tailwind close icon

* Fix #5546: prop type error in console

* Fix #5555: BodyCell frozen issue

* Fix #5561: Inplace respect active prop

* Fix #5568: MultiSelect filterInput PT

* Fix #5572: Multselect selectAllLabel was being added to DOM

* Tooltip fix Tailwind CSS

* Dialog Breakpoints

* Calendar disabled date handling

* Fix #5609: ToggleButton focusedState

* Fix #5610: Radio/Checkbox always fire onClick

* fix: #5613, TreeSelect: TreeSelect component is not supporting tooltips and is an issue in multiple select mode

* Fix #5623 - Otherprops not working for InputSwitch

* fix:Calendar not showing correctly in Table

* fix:Image preview zoom in bug

* Fix #5637: Sidebar aria-label close

* Accept array as PT value

* Datatable breakpoints

* fix:ConfirmDialog: acceptButton's pt don't respect button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

Fix #5523: BlockUI return activeElement focus melloware/primereact
2 participants
@melloware @tampham1210