-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown (Tailwind): Focus shadow not working #5512
Comments
Not sure what you mean by Shadow? @Dalorzo |
@melloware taking a look at this moment, will revert in a bit |
@countersoda can you please elaborate why the dropdown should have a shadow? Is this because of a dark mode? |
@melloware I found what I think could be the issue: From docs, I can update the input area, however, any styling applied to input does not get reflected while using the dropdown, more specifically or problematic focus, hover, active. The styles are set to the input correctly, those are just not visible to user, <Dropdown
options={items}
value={value}
pt={{
input: {
className: "bg-blue-50 focus:bg-blue-900 active:bg-blue-700",
},
}}
onChange={(e) => setValue(e.value)}
/> |
@Dalorzo when I compare to AutoComplete input: ({ props }) => ({
root: {
className: classNames(
'm-0',
'transition-colors duration-200 appearance-none rounded-lg',
{ 'rounded-tr-none rounded-br-none': props.dropdown },
{
'font-sans text-base text-gray-700 dark:text-white/80 bg-white dark:bg-gray-900 p-3 border border-gray-300 dark:border-blue-900/40 focus:outline-offset-0 focus:shadow-[0_0_0_0.2rem_rgba(191,219,254,1)] dark:focus:shadow-[0_0_0_0.2rem_rgba(147,197,253,0.5)] hover:border-blue-500 focus:outline-none':
!props.multiple,
'font-sans text-base text-gray-700 dark:text-white/80 border-0 outline-none bg-transparent m-0 p-0 shadow-none rounded-none w-full': props.multiple
}
)
}
}), |
@countersoda I think you are correct, I was able to workaround the issue of the |
I see if you do this even with tabIndex="-1" you can see it. <Dropdown
options={items}
value={value}
onChange={(e) => setValue(e.value)}
pt={{
input: {
className: "bg-blue-50 focus:bg-blue-900 active:bg-blue-700",
tabIndex: "-1",
},
}}
/> |
@Dalorzo where did we end up on this? |
* Fix #5485: Messages restore close animation * Fix #5490: useDebounce fixed * Fix #5492: Listbox passthrough fixes * Fix #5493: Multiselect passthrough fixes * Fix #5485: Messages restore close animation * Fix #5499: Autocomplete/Chips PT fixes * Fix #5479: CascadeSelect PT fixes * Fix #5509: Button loadingIcon Tailwind fix * Fix #5512: Dropdown add tabindex for Tailwind * Support roundingMode for InputNumber * Fix #5523: BlockUI return activeElement focus * Fix #5530: Chip onRemove event pass value * DataTable:converted to data- lookups instead of className lookups * Fix #5543: OverlayPanel Tailwind close icon * Fix #5546: prop type error in console * Fix #5555: BodyCell frozen issue * Fix #5561: Inplace respect active prop * Fix #5568: MultiSelect filterInput PT * Fix #5572: Multselect selectAllLabel was being added to DOM * Tooltip fix Tailwind CSS * Dialog Breakpoints * Calendar disabled date handling * Fix #5609: ToggleButton focusedState * Fix #5610: Radio/Checkbox always fire onClick * fix: #5613, TreeSelect: TreeSelect component is not supporting tooltips and is an issue in multiple select mode * Fix #5623 - Otherprops not working for InputSwitch * fix:Calendar not showing correctly in Table * fix:Image preview zoom in bug * Fix #5637: Sidebar aria-label close * Accept array as PT value * Datatable breakpoints * fix:ConfirmDialog: acceptButton's pt don't respect button
Describe the bug
The dropdown does not show a shadow when focused.
Reproducer
https://codesandbox.io/p/sandbox/frosty-hoover-ttd938
PrimeReact version
10.2.1
React version
18.x
Language
TypeScript
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
Expected behavior
The dropdown should have a shadow
The text was updated successfully, but these errors were encountered: