-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.0.0 #298
Merged
Release v4.0.0 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-it
commented
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
…#246 (#280) ## 🎯 Aim The aim is to refactor the way start and run commands in integrated VS Code terminal. The idea is to aling the approach by using the dedicated Terminal service which was developed for exactly that. ## ✅ What was done - [X] Removes all direct usage of `terminal` and refactors it to same approach ## 🔗 Related issue Closes: #246
…sions. Closes: #200 (#281) ## 🎯 Aim This PR implements the required settings of issue [#200](#200). ## 📷 Result ![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703) ## ✅ What was done Added two settings for the extension: - showServiceIncidentList - showTenantWideExtensions Updated the `TerminalCommandExecuter` extracting the `getExtensionSettings` method and creating a dedicated util file. Updated the `CommandPanel` to keep into account the new settings when loading and showing data. ## 🔗 Related issue Closes: #200 --------- Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Adam Wójcik <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Adam Wójcik <[email protected]>
## 🎯 Aim The aim is to make account and enviroment views more bulletproof and properly display views when CLI command extecution gets rejected due to lack of permission ## 📷 Result ![image](https://github.com/user-attachments/assets/4b49a22d-a33f-4785-ab31-e6b73afe21e9) ## ✅ What was done - [X] Added simple error handling to cover the reject case ## 🔗 Related issue Closes: #278
## 🎯 Aim Adding an extra filter to Sample gallery so that we can filter on the extension type. Filter can only be visible when extension type is selected 'Component Type' ## 📷 Result ![image](https://github.com/pnp/vscode-viva/assets/35696168/c8c2e084-5831-4fc4-861e-ad4c4c0845d7) ## ✅ What was done - [X] Added Extension filter dropdown - [X] Added functionality so that extension filter is only visible when extension is selected in the Component Type dropdown - [X] Added filter functionality so that samples get filtered based on selected value in extension dropdown - [x] Added filter functionality so that samples don't get filtered when extensions dropdown has selected values but extension is not selected in component type dropdown ## 🔗 Related issue Closes: #219
## 🎯 Aim The aim is to update the default sign in method to add functionality to sign in over local entra app registration and also add additional features that will allow to create such an app reg as easily as possible ## 📷 Result ![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d) ## ✅ What was done - [X] Refactored project structure - [X] Updated readme images - [X] Updated walkthrough steps to add more guidance - [X] Added form that will create entra app reg for SPFx using CLI for M365 - [X] Refactored sign in experiance - [X] Minor bug fix in sample gallery filters ## 🔗 Related issue Closes: #291, #266, #265, #225
nicodecleyre
added a commit
to nicodecleyre/vscode-viva
that referenced
this pull request
Oct 20, 2024
## 🎯 Aim The aim is to prepare a new major release with the latest changes that introduced improvements in the welcome experience, filter sample gallery, settings and new login experience. ## 📷 Result ![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/bc27ede2-368f-40ff-9222-f9c02cedd857) ![sign-in-options](https://github.com/user-attachments/assets/c36c1886-cfed-44eb-8bb9-c706c9b166eb) ![settings](https://github.com/user-attachments/assets/509653cd-0c38-4c5d-8c63-cfd7a63976e7) ## ✅ What was done - [X] Updated Sign in method - [X] Updated SPFx Intro and workspace setup walkthrough steps - [X] Updated readme assets - [X] Added form to create Entra App Registration required for sign in - [X] Added Extension filter dropdown to the sample gallery - [X] Updated account view to show the Entra App Registration - [X] Updated terminal usage to unified approach - [X] Updated release workflows - [X] Added settings to show and hide health incidents and tenant wide extensions ## 🔗 Related issue Closes: pnp#291 --------- Co-authored-by: Guido Zambarda <[email protected]> Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Nico De Cleyre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
The aim is to prepare a new major release with the latest changes that introduced improvements in the welcome experience, filter sample gallery, settings and new login experience.
📷 Result
✅ What was done
🔗 Related issue
Closes: #291