-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Sign in method. Closes: #291, #266, #265, #225 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-it
changed the title
Updates sing in logic. Closes: #291
Updates Sign in method. Closes: #291
Sep 7, 2024
Adam-it
changed the title
Updates Sign in method. Closes: #291
Updates Sign in method. Closes: #291, #266, #265, #225
Sep 7, 2024
This was
linked to
issues
Sep 7, 2024
Adam-it
commented
Sep 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Adam-it
force-pushed
the
update-login-method
branch
from
September 8, 2024 00:04
e091b94
to
4b1c949
Compare
Adam-it
added a commit
that referenced
this pull request
Sep 8, 2024
## 🎯 Aim The aim is to update the default sign in method to add functionality to sign in over local entra app registration and also add additional features that will allow to create such an app reg as easily as possible ## 📷 Result ![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d) ## ✅ What was done - [X] Refactored project structure - [X] Updated readme images - [X] Updated walkthrough steps to add more guidance - [X] Added form that will create entra app reg for SPFx using CLI for M365 - [X] Refactored sign in experiance - [X] Minor bug fix in sample gallery filters ## 🔗 Related issue Closes: #291, #266, #265, #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
The aim is to update the default sign in method to add functionality to sign in over local entra app registration and also add additional features that will allow to create such an app reg as easily as possible
📷 Result
✅ What was done
🔗 Related issue
Closes: #291, #266, #265, #225