Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Sign in method. Closes: #291, #266, #265, #225 #296

Merged
merged 12 commits into from
Sep 8, 2024

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Sep 6, 2024

🎯 Aim

The aim is to update the default sign in method to add functionality to sign in over local entra app registration and also add additional features that will allow to create such an app reg as easily as possible

📷 Result

sign-in-entra-app-reg-form

✅ What was done

  • Refactored project structure
  • Updated readme images
  • Updated walkthrough steps to add more guidance
  • Added form that will create entra app reg for SPFx using CLI for M365
  • Refactored sign in experiance
  • Minor bug fix in sample gallery filters

🔗 Related issue

Closes: #291, #266, #265, #225

@Adam-it Adam-it changed the base branch from main to dev September 6, 2024 23:10
@Adam-it Adam-it self-assigned this Sep 6, 2024
@Adam-it Adam-it changed the title Updates sing in logic. Closes: #291 Updates Sign in method. Closes: #291 Sep 7, 2024
@Adam-it Adam-it changed the title Updates Sign in method. Closes: #291 Updates Sign in method. Closes: #291, #266, #265, #225 Sep 7, 2024
@Adam-it Adam-it marked this pull request as ready for review September 7, 2024 23:50
Copy link
Member Author

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adam-it Adam-it force-pushed the update-login-method branch from e091b94 to 4b1c949 Compare September 8, 2024 00:04
@Adam-it Adam-it merged commit d79ac32 into pnp:dev Sep 8, 2024
Adam-it added a commit that referenced this pull request Sep 8, 2024
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
@Adam-it Adam-it deleted the update-login-method branch September 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment