Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Improve SharePoint Framework introduction in walkthrough #265

Closed
Adam-it opened this issue Jun 30, 2024 · 1 comment · Fixed by #296
Closed

💡 [Feature]: Improve SharePoint Framework introduction in walkthrough #265

Adam-it opened this issue Jun 30, 2024 · 1 comment · Fixed by #296
Assignees
@Adam-it
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone
v3.X

Comments

@Adam-it
Copy link
Member

Adam-it commented Jun 30, 2024

🎯 Aim of the feature

The aim of the walkthrough is to provide step by step guidance and introduction to SharePoint Framework development and SPFx Toolkit. Unfortunately, the first step which should give guidance regarding SPFx is very small and general. Doesn't include any details and helpful guidance. We should improve this.

image

we should add information that will explain

  • more about SPFx capabilities and features.
  • why would someone pick SPFx over a different extensibility model
  • what components are possible to be created
  • some general info about basic setup

📷 Images (if possible) with expected result

No response

🤔 Additional remarks or comments

We should be updating those parts

image
@Adam-it Adam-it added ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Jun 30, 2024
@Adam-it Adam-it added this to the v3.X milestone Jul 28, 2024
@Adam-it Adam-it linked a pull request Sep 7, 2024 that will close this issue
Updates Sign in method. Closes: #291, #266, #265, #225 #296
Merged
6 tasks
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
d79ac32 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Sep 8, 2024
@Adam-it Adam-it self-assigned this Sep 8, 2024
@Adam-it
Copy link
Member Author

Adam-it commented Sep 8, 2024

done ✅

@Adam-it Adam-it closed this as completed Sep 8, 2024
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
083d2e9 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v3.X
Development

Successfully merging a pull request may close this issue.

Updates Sign in method. Closes: #291, #266, #265, #225 Adam-it/vscode-viva
1 participant
@Adam-it