Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-spfx19-support #234

Closed
wants to merge 5 commits into from
Closed

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented May 10, 2024

🎯 Aim

Is to update the dependency check to align it with SPFx v1.19.0

βœ… What was done

  • Updated versions of dependencies that should be checked with SPFx.
  • updated local copy of CLI to support spfx project upgrade and doctor commands with SPFx v1.19

πŸ”— Related issue

Closes: #233

Tanddant and others added 5 commits April 16, 2024 02:52
pnp#214)

…o fail

## 🎯 Aim

Goal is to solve pnp#212 

## πŸ“· Result

Folder path now wrapped in quotes

![image](https://github.com/pnp/vscode-viva/assets/6947024/02c83bdd-b71f-4773-8f4f-ce93787423c7)

## βœ… What was done

Hopefully nothing else needs to be done πŸ™Œ

## πŸ”— Related issue

Closes: pnp#212
## 🎯 Aim

Solve pnp#209, and to give @Adam-it a PR as B-day present πŸ₯³ 🎈 

## πŸ“· Result


![image](https://github.com/pnp/vscode-viva/assets/35696168/2761ac22-9a27-4a55-8652-f58b1ed9abf7)

## βœ… What was done

- [ ] Didn't removed 'Current' from `CliActions.ts` ==> Don't know if
you want me te remove 'Current' from there too? πŸ€”
- [X] Removed 'Current' in `README.md`
- [X] Removed 'Current' in `tasks-and-actions.md`
- [X] Removed 'Current' in `CommandPanel.ts`

## πŸ”— Related issue

Closes: pnp#209
@Adam-it Adam-it closed this May 10, 2024
@Adam-it Adam-it deleted the update-spfx19-support branch May 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants