Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Add support for SPFx v1.19 #233

Closed
Adam-it opened this issue May 8, 2024 · 1 comment · Fixed by #236
Closed

💡 [Feature]: Add support for SPFx v1.19 #233

Adam-it opened this issue May 8, 2024 · 1 comment · Fixed by #236
Assignees
@Adam-it
Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it

Comments

@Adam-it
Copy link
Member

Adam-it commented May 8, 2024

🎯 Aim of the feature

Since SPFx v1.19 is GA and we added this support to CLI we may now move this to SPFx Toolkit
pnp/cli-microsoft365@55f4e2f

📷 Images (if possible) with expected result

No response

🤔 Additional remarks or comments

before we proceed we need to update the cli-cjs branch
@Adam-it Adam-it added ⭐ enhancement New feature or request 👨‍💻work in progress I am working on it labels May 8, 2024
@Adam-it Adam-it self-assigned this May 8, 2024
@Adam-it
Copy link
Member Author

Adam-it commented May 9, 2024 •
edited
Loading

  • cherry pick CLI SPFx 1.19 support
  • revert to cjs
  • update dependency check in SPFx toolkit to check for specifc version and remove older version of node
  • pre-release check
  • fixup in readme to remove node 16 support
  • release
  • rebase dev branch and force push

This was referenced May 10, 2024
Closed
Merged
Adam-it added a commit that referenced this issue May 10, 2024
@Adam-it
Updates dependency check. Closes: #233 (#235)
18e8eb3 
## 🎯 Aim

Add support for SPFx v1.19.0

Closes: #233
@Adam-it Adam-it mentioned this issue May 12, 2024
Merged
Adam-it added a commit that referenced this issue May 12, 2024
@Adam-it
Release v3.2.0 (#236)
e27d067 
## 🎯 Aim

Release 3.2.0 that adds SPFx 1.19.0 support

## 🔗 Related issue

Closes: #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v3.2.0 pnp/vscode-viva
1 participant
@Adam-it