Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for NVS (#180) #199

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Support for NVS (#180) #199

merged 6 commits into from
Mar 22, 2024

Conversation

hugoabernier
Copy link
Contributor

@hugoabernier hugoabernier commented Mar 19, 2024 •
edited by Adam-it
Loading

🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code Setting to control the choice. As discussed with @VesaJuvonen, needed for upcoming SPFx workshops.

📷 Result

image

✅ What was done

Added a VSCode setting, and logic to change the command when launching a new terminal.

🔗 Related issue

No issues man, we're all good!

@hugoabernier hugoabernier changed the title Sample data update (#180) Support for NVS (#180) Mar 19, 2024
@Adam-it Adam-it self-assigned this Mar 19, 2024
Adam-it
Adam-it requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugoabernier awesome work 👏
tested locally, works really good ✅
I added a few clean up comments. Please recheck them before we merge 👍
Let me know if something is unclear 🙏

README.md Outdated Show resolved Hide resolved
src/services/TerminalCommandExecuter.ts Outdated Show resolved Hide resolved
src/services/TerminalCommandExecuter.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft March 20, 2024 01:27
@Adam-it
Copy link
Member

Adam-it commented Mar 20, 2024

@hugoabernier Thank you for this awesome suggestion and PR.
I rebased the dev branch so that this PR is now clean. Please for future reference start your branch from dev not main to avoid unnecessary conflicts👍
I reviewed your PR and added a few minor comments. Mostly small clean up details. Please double-check them and after they are resolved click on the ready to review button on this PR so we may proceed with merging 👍
Also please do let me know if something is unclear or the SPFx workshop you mentioned is coming shortly and you won't have time to resolve those comments, in that case, I will do that for you 😉.
As soon as this is merge I will create a new pre-release so you may start using Viva Toolkit with this change ASAP.
I plan to do next minor/major by the end of this month.
Cheers.

hugoabernier and others added 2 commits March 22, 2024 10:34
@hugoabernier hugoabernier marked this pull request as ready for review March 22, 2024 14:34
@hugoabernier
Copy link
Contributor Author

@Adam-it looks great, please proceed at your convenience

@Adam-it Adam-it merged commit 727ca41 into pnp:dev Mar 22, 2024
@Adam-it
Copy link
Member

Adam-it commented Mar 22, 2024

Merged manually.
Thank you for your awesome work 👏

@Adam-it
Copy link
Member

Adam-it commented Mar 23, 2024

@hugoabernier your change is present in the latest pre-release 2.6.1 🚀
image

remember that in order to install a pre-release you need to click on the switch to pre-release button in the extension view in VS Code to opt-in.

Thank you for contributing to Viva Toolkit 👏

@hugoabernier hugoabernier deleted the nvs-support branch March 25, 2024 02:22
Adam-it added a commit that referenced this pull request Mar 27, 2024
@hugoabernier @Adam-it
Support for NVS (#180) (#199)
8a2de77 
## 🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code
Setting to control the choice. As discussed with @VesaJuvonen, needed
for upcoming SPFx workshops.

## 📷 Result

![image](https://github.com/pnp/vscode-viva/assets/13972467/1e0f7a21-10db-442d-9c6e-7e10fd21cd64)

## ✅ What was done

Added a VSCode setting, and logic to change the command when launching a
new terminal.

## 🔗 Related issue

No issues man, we're all good!

---------

Co-authored-by: Hugo Bernier <hugoabernier#live.ca>
Co-authored-by: Adam Wójcik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugoabernier @Adam-it