Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample data update #180

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Sample data update #180

merged 1 commit into from
Feb 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated check and update of SPFx extensions and webparts samples data and aces sample data.

@Adam-it Adam-it self-assigned this Feb 17, 2024
@Adam-it Adam-it merged commit 43d4d4f into main Feb 17, 2024
2 checks passed
@Adam-it Adam-it deleted the update-sample-data branch February 17, 2024 21:51
Adam-it added a commit that referenced this pull request Mar 22, 2024
## 🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code
Setting to control the choice. As discussed with @VesaJuvonen, needed
for upcoming SPFx workshops.

## 📷 Result

![image](https://github.com/pnp/vscode-viva/assets/13972467/1e0f7a21-10db-442d-9c6e-7e10fd21cd64)

## ✅ What was done

Added a VSCode setting, and logic to change the command when launching a
new terminal.

## 🔗 Related issue

No issues man, we're all good!

---------

Co-authored-by: Hugo Bernier <hugoabernier#live.ca>
Co-authored-by: Adam Wójcik <[email protected]>
Adam-it added a commit that referenced this pull request Mar 27, 2024
## 🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code
Setting to control the choice. As discussed with @VesaJuvonen, needed
for upcoming SPFx workshops.

## 📷 Result

![image](https://github.com/pnp/vscode-viva/assets/13972467/1e0f7a21-10db-442d-9c6e-7e10fd21cd64)

## ✅ What was done

Added a VSCode setting, and logic to change the command when launching a
new terminal.

## 🔗 Related issue

No issues man, we're all good!

---------

Co-authored-by: Hugo Bernier <hugoabernier#live.ca>
Co-authored-by: Adam Wójcik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant