Support for NVS (#180) (#199)

## 🎯 Aim

Adds support for NVM, NVS, or no Node Version Manager, and a VS Code
Setting to control the choice. As discussed with @VesaJuvonen, needed
for upcoming SPFx workshops.

## 📷 Result

![image](https://github.com/pnp/vscode-viva/assets/13972467/1e0f7a21-10db-442d-9c6e-7e10fd21cd64)

## ✅ What was done

Added a VSCode setting, and logic to change the command when launching a
new terminal.

## 🔗 Related issue

No issues man, we're all good!

---------

Co-authored-by: Hugo Bernier <hugoabernier#live.ca>
Co-authored-by: Adam Wójcik <[email protected]>

README.md

@@ -252,6 +252,12 @@ Check it out in action 👇
 
 [Check out our docs for more details](https://github.com/pnp/vscode-viva/wiki/6-Teams-Toolkit-Integration)
 
+### 1️⃣2️⃣ Node.js Version Manager Support
+
+By default, the Viva Connections Toolkit will use the Node.js version that is installed on your machine. If you want to use a different version, you can use a Node.js Version Manager such as [nvm](https://github.com/nvm-sh/nvm) or [nvs](https://github.com/jasongin/nvs). The Viva Connections Toolkit will detect the preferred version of Node.js if a `.nvmrc` file is present in the root of your project, and will use that version for all the actions.
+
+You can use the settings to change which Node.js version manager you want to use. You may choose between `nvm` and `nvs`. If you wish to avoid using a Node.js version manager, you can set the value to `none`
+
 ## ⚙️ Architecture
 
 Viva Connections Toolkit for Visual Studio Code is an abstraction layer on top of the [SPFx](https://aka.ms/spfx) Yeoman generator and [CLI for Microsoft 365](https://pnp.github.io/cli-microsoft365/). 

package.json

@@ -2,7 +2,7 @@
 	"name": "viva-connections-toolkit",
 	"displayName": "Viva Connections Toolkit",
 	"description": "Viva Connections Toolkit aims to boost your productivity in developing and managing SharePoint Framework solutions helping at every stage of your development flow, from setting up your development workspace to deploying a solution straight to your tenant without the need to leave VS Code and now even create a CI/CD pipeline to introduce automate deployment of your app. This toolkit is provided by the community.",
-	"version": "2.6.0",
+	"version": "2.6.1",
 	"publisher": "m365pnp",
 	"preview": false,
 	"homepage": "https://github.com/pnp/vscode-viva",
@@ -45,6 +45,22 @@
 	"license": "MIT",
 	"main": "./dist/extension.js",
 	"contributes": {
+		"configuration": {
+			"title": "Viva Connections Toolkit",
+			"properties": {
+				"viva-connections-toolkit.nodeVersionManager": {
+					"title": "Node.js Version Manager",
+					"type": "string",
+					"default": "nvm",
+					"enum": [
+						"nvm",
+						"nvs",
+						"none"
+					],
+					"description": "Choose your preferred Node.js version manager. Choose between `nvs`, `nvm`, or `none`."
+				}
+			}
+		},
 		"icons": {
 			"spo-m365": {
 				"description": "Microsoft 365 icon",

src/constants/NodeVersionManagers.ts

@@ -0,0 +1,7 @@
+/* eslint-disable no-unused-vars */
+// eslint-disable-next-line no-shadow
+export enum NodeVersionManagers {
+    nvm = 'nvm',
+    nvs = 'nvs',
+    none = 'none'
+}

src/constants/index.ts

@@ -5,6 +5,7 @@ export * from './ContextKeys';
 export * from './ExtensionTypes';
 export * from './FrameworkTypes';
 export * from './General';
+export * from './NodeVersionManagers';
 export * from './ProjectFileContent';
 export * from './WebviewCommand';
 export * from './WebViewTypes';

src/services/TerminalCommandExecuter.ts

@@ -1,5 +1,5 @@
 import { commands, ThemeIcon, workspace, window, Terminal } from 'vscode';
-import { Commands } from '../constants';
+import { Commands, EXTENSION_NAME, NodeVersionManagers } from '../constants';
 import { Subscription } from '../models';
 import { Extension } from './Extension';
 import { getPlatform } from '../utils';
@@ -74,16 +74,30 @@ export class TerminalCommandExecuter {
         iconPath: icon ? new ThemeIcon(icon) : undefined
       });
 
+      // Check the user's settings to see if they want to use nvm or nvs
+      // Get the user's preferred node version manager -- nvm or nvs or none, if they don't want to use either
+      const nodeVersionManager: string = TerminalCommandExecuter.getExtensionSettings('nodeVersionManager', 'nvm');
+
       // Check if nvm is used
       const nvmFiles = await workspace.findFiles('.nvmrc', '**/node_modules/**');
-      if (nvmFiles.length > 0) {
-        terminal.sendText('nvm use');
+
+      // If there are .nvmrc files and the user wants to use nvm, then use their preferred node version manager
+      if (nvmFiles.length > 0 && nodeVersionManager !== NodeVersionManagers.none) {
+        if (nodeVersionManager === NodeVersionManagers.nvs) {
+          terminal.sendText('nvs use');
+        } else {
+          terminal.sendText('nvm use');
+        }
       }
     }
 
     return terminal;
   }
 
+  private static getExtensionSettings<T>(setting: string, defaultValue: T): T {
+      return workspace.getConfiguration(EXTENSION_NAME).get<T>(setting, defaultValue);
+  }
+
   private static async runInTerminal(command: string, terminal?: Terminal | undefined) {
     if (terminal) {
       terminal.show(true);