Drop sbt 0.13 support #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasi35
approved these changes
Dec 18, 2019
project/plugins.sbt
Outdated
| @@ -1,4 +1,4 @@ | |||
| addSbtPlugin("com.typesafe.play" % "interplay" % sys.props.get("interplay.version").getOrElse("2.1.4")) | |||
| addSbtPlugin("com.typesafe.play" % "interplay" % sys.props.get("interplay.version").getOrElse("2.1.5-ee0cdca")) | |||
There was a problem hiding this comment.
If only interplay was using sbt-dynver 
41 tasks
ignasi35
approved these changes
Dec 19, 2019
ihostage
reviewed
Aug 25, 2023
| libraryDependencies ++= scalaParserCombinators(scalaVersion.value), | ||
| libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % "test", | ||
| libraryDependencies += "org.scalatest" %%% "scalatest" % ScalaTestVersion % "test", | ||
| libraryDependencies += "org.scala-lang.modules" %% "scala-parser-combinators" % ScalaParserCombinatorsVersion % "optional", |
There was a problem hiding this comment.
@marcospereira @mkurz
Folks, do you remember, why scope of scala-parser-combinators was changed to optional? 🤔
There was a problem hiding this comment.
I don't think optional makes sense here anymore. It was added in f288c70. I checked out that revision, removed scala-parser-combinators and it still compiled. It seems things changed since then.
We can remove optional here I think since twirl seems to not work anymore without scala-parser-combinators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on playframework/interplay#101