Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-parser-combinators shouldn't be optional dependency #655

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

ihostage
Copy link
Member

Details in #294 (comment)

@ihostage ihostage requested a review from mkurz August 28, 2023 10:00
@ihostage ihostage added this to the 1.6.0 milestone Aug 28, 2023
@mkurz
Copy link
Member

mkurz commented Aug 28, 2023

Hey Sergey, please remove Optional in line 127 as well, thanks!

@ihostage
Copy link
Member Author

Oooops, sorry 🤦‍♂️ Thank you, Matthias! 👍

@mkurz mkurz merged commit 86170a6 into playframework:main Aug 28, 2023
@ihostage ihostage deleted the fix-deps branch August 28, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants