Travis: rename stage; allow version branches #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasi35
reviewed
Jun 2, 2020
| @@ -58,6 +59,7 @@ jobs: | |||
|
|
|||
| stages: | |||
| - name: validations | |||
| - name: test | |||
There was a problem hiding this comment.
I'd keep validations and test in a single stage. A silly error in validations will mask further errors in test.
How about splitting the following way:
- validations and tests-JDK11 (3 jobs in the first stage both scala 2.12 and 2.13)
- tests-JDK8 (2 extra jobs)
- other stages
There was a problem hiding this comment.
It's the wasted Travis jobs I wanted to get rid off, it's now as before.
There was a problem hiding this comment.
Sure. I come from maintaining 40+min builds so these wasted travis jobs look like peanuts. :-)
ignasi35
suggested changes
Jun 2, 2020
ennru
changed the title
ignasi35
approved these changes
Jun 5, 2020
| - /^\d+\.\d+(\.\d+)?(-\S*)?$/ |
| @@ -58,6 +59,7 @@ jobs: | |||
|
|
|||
| stages: | |||
| - name: validations | |||
| - name: test | |||
There was a problem hiding this comment.
Sure. I come from maintaining 40+min builds so these wasted travis jobs look like peanuts. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update readme
references #294