Pin Docker image version in Buildkite #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
fix-buildkite
branch
from
72d485a to
933ab4b
Compare
frouioui
approved these changes
Mar 20, 2023
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
changed the title
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
|
I think there is test failure still due to some user issue .. https://buildkite.com/planetscale/vitess-operator/builds/474#01870310-a19c-4865-b9de-ebc4e9abf9db |
|
should we do the change with |
Yes we should |
Signed-off-by: Florent Poinsard <[email protected]>
|
@frouioui We'll have to make corresponding changes to the operator example in the Vitess repo too. Let's do that after we fix everything on this PR. |
Yes, I have an action item for this |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Apr 6, 2023
Comment on lines
+1
to
+2
| #!/bin/bash | ||
|
|
There was a problem hiding this comment.
ah, forgot to remove this before the merge. I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pins the docker version in buildkite because of recent bug we ran into. The bug has been described in detail in docker/cli#4103.
This PR also updates the init_db.sql files for the examples after the changes made for super-read-only in vitessio/vitess#12206
EDIT - The bug linked above had a response and the fix is to install
gcompat. That has also been fixed in this PR.Fixes: vitessio/vitess#12678