Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PodDisruptionBudget to policy/v1 #397

Merged
merged 32 commits into from
Apr 6, 2023
Merged

Update PodDisruptionBudget to policy/v1 #397

merged 32 commits into from
Apr 6, 2023

Conversation

jcarrig
Copy link
Contributor

@jcarrig jcarrig commented Mar 17, 2023

  • policy/v1beta1 is deprecated in v1.21.0+ and unavailable in v1.25+
  • replaced policy/v1beta1 with policy/v1
  • update kubernetes version to support policy/v1
  • refactor integration test to support updated kubernetes version

jcarrig added 30 commits March 17, 2023 16:52
@jcarrig
update policy/v1beta to policy/v1 for kubernetes v1.25 support
5f89535 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
trigger workflows
e56a747 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
Revert "update policy/v1beta to policy/v1 for kubernetes v1.25 support"
bc5758d 
This reverts commit faeb0f3.

Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
Revert "Revert "update policy/v1beta to policy/v1 for kubernetes v1.2…
604214c 
…5 support""

This reverts commit 65639b3.

Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
change kube version to v1.24.11
c8bf1e8 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
more logs in apiserver
0e2bd4a 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
remove --insecure-port
4cf5b3c 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
add required flags
5c08a1e 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
syntax
6ca61ab 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
use data dir
47a79ed 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
short circuit test
aa62f61 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
only try to start api server
75c64ff 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
use abac auth
f0ae685 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
config set-context
10714bd 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
try with anonymous user
bfda9c2 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
try with equals
56f8e7d 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
fix args
aa1e5cb 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
start etcd
d405bd4 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
revert issuer
0b36365 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
add docker images
a137396 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
add script to start etcd
1c9323b 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
add kube-apiserver-up
186645b 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
move into folder and add readme
030800d 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
see if test passes
a028ac7 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
test again
4743242 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
run tests
d6fdb77 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
cleanup cmdline kubectl
ba05768 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
cleanup
bdb47e5 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
more cleanup
5b89a25 
Signed-off-by: Jack Carrig <[email protected]>
@jcarrig
generate random token
e4f183d 
Signed-off-by: Jack Carrig <[email protected]>
frouioui
frouioui approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much for contributing this PR, this is truly helpful.

This was referenced Mar 20, 2023
Closed
Closed
@frouioui
Copy link
Member

Hey @jcarrig, can you also modify the Compatibility table on the README to say that latest is supported on k8s 1.25?

@jcarrig
Copy link
Contributor Author

jcarrig commented Mar 20, 2023

Hey @jcarrig, can you also modify the Compatibility table on the README to say that latest is supported on k8s 1.25?

@frouioui - yes, should i also update the integration tests to use v1.25?

@frouioui
Copy link
Member

@frouioui - yes, should i also update the integration tests to use v1.25?

Ah good catch, yes please 😄

Regarding the failing buildkite workflows, these can be ignored for now, they will be fixed via #398.

@jcarrig
Copy link
Contributor Author

jcarrig commented Mar 20, 2023

@frouioui -- done 👍

@frouioui
Copy link
Member

frouioui commented Apr 6, 2023

Hello @jcarrig! Great news. We will finally move forward with this Pull Request. We needed a certain amount of time to fix an ongoing issue with our build and #398 just got merged. I merged main onto your branch, let's wait for CI and merge your code.

Thanks for your patience.

@frouioui frouioui merged commit 9398685 into planetscale:main Apr 6, 2023
This was referenced Apr 11, 2023
Closed
Merged
Merged
Merged
@frouioui frouioui mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarrig @frouioui