-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PodDisruptionBudget to policy/v1 #309
Conversation
@joneug can you fix the DCO and force-push? We cannot accept any contributions without a sign-off. |
policy/v1beta1 is deprecated in v1.21.0+ and unavailable in v1.25+. Signed-off-by: Jonathan Neugebauer <[email protected]>
The changes look good to me, but the integration-test seem to be failing consistently. |
@GuptaManan100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (tests pending)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me. I'll monitor the CI status after merging main into this branch.
…5.4 and etcd v3.5.6 Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Guys, as K8s 1.25 getting more wide presence, this problem should get more attention. |
any updates on this PR? I have been testing this branch with k8s v1.25 and it seems to be working well. |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Closing this Pull Request, the issue will be resolved by #397 (review). Thank you. |
policy/v1beta1 is deprecated in v1.21.0+ and
unavailable in v1.25+.