Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PodDisruptionBudget to policy/v1 #309

Closed
wants to merge 9 commits into from

Conversation

joneug
Copy link

@joneug joneug commented Sep 7, 2022

policy/v1beta1 is deprecated in v1.21.0+ and
unavailable in v1.25+.

@deepthi
Copy link
Collaborator

deepthi commented Sep 15, 2022

@joneug can you fix the DCO and force-push? We cannot accept any contributions without a sign-off.

policy/v1beta1 is deprecated in v1.21.0+ and
unavailable in v1.25+.

Signed-off-by: Jonathan Neugebauer <[email protected]>
@GuptaManan100
Copy link
Collaborator

The changes look good to me, but the integration-test seem to be failing consistently.

@Verolop
Copy link
Contributor

Verolop commented Sep 21, 2022

@GuptaManan100 signal:killed might indicate that the test is running out of memory. Looking for options.

Copy link
Contributor

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tests pending)

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. I'll monitor the CI status after merging main into this branch.

@Areso
Copy link

Areso commented Jan 2, 2023

Guys, as K8s 1.25 getting more wide presence, this problem should get more attention.

@de-metavision
Copy link

any updates on this PR? I have been testing this branch with k8s v1.25 and it seems to be working well.
I would really love to see this merged and released soon.

@frouioui
Copy link
Member

Closing this Pull Request, the issue will be resolved by #397 (review). Thank you.

@frouioui frouioui closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants