-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTAdmin] Change vars from REACT_APP to VITE #404
Conversation
Went through the repository and it does not seem like we need to change anything, i'll let @GuptaManan100 confirm though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
'REACT_APP_VTADMIN_API_ADDRESS': "%s", | ||
'REACT_APP_FETCH_CREDENTIALS': "omit", | ||
'REACT_APP_ENABLE_EXPERIMENTAL_TABLET_DEBUG_VARS': false, | ||
'REACT_APP_BUGSNAG_API_KEY': "", | ||
'REACT_APP_DOCUMENT_TITLE': "", | ||
'REACT_APP_READONLY_MODE': %s, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably keep the old env variables for one release to ensure backward compatibility.
We can drop these after 2.10 release
Rebased on |
7030b42
to
a3a84d4
Compare
Signed-off-by: Florent Poinsard <[email protected]>
a3a84d4
to
e888bcf
Compare
…vitess-operator into frances/update-vtadmin-vite
With vitessio/vitess#12831, we're migrating VTAdmin from create-react-app to vite. One of the changes is that all
REACT_APP_*
vars are changed toVITE_*