Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller(cdc): debug frontier #10202

Merged
merged 2 commits into from
Dec 1, 2023
Merged

puller(cdc): debug frontier #10202

merged 2 commits into from
Dec 1, 2023

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 30, 2023

What problem does this PR solve?

Issue Number: ref #10181

What is changed and how it works?

Add some debug code for stuck ResolvedTs in puller.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 30, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 30, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 11:43:54.131393687 +0000 UTC m=+1095862.796619882: ☑️ agreed by nongfushanquan.
  • 2023-11-30 12:33:12.815091245 +0000 UTC m=+1098821.480317440: ☑️ agreed by sdojjy.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2023

/retest

@hicqu hicqu added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023
Signed-off-by: qupeng <[email protected]>
@hicqu hicqu merged commit e80e6dd into pingcap:master Dec 1, 2023
3 checks passed
@hicqu hicqu deleted the debug-frontier branch December 1, 2023 07:37
hicqu added a commit to hicqu/ticdc that referenced this pull request Dec 5, 2023
hicqu added a commit that referenced this pull request Dec 5, 2023
* cdc: fixes minor bugs #10168 and #10169 (#10170)
* puller(cdc): debug frontier (#10202)
* kv-client(cdc): correct conditions of canceling grpc streams  (#10237)

Signed-off-by: qupeng <[email protected]>
@hicqu hicqu added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 8, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Dec 8, 2023

/cherry-pick

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10269.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10270.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10271.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 8, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 8, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 8, 2023
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request Dec 18, 2023
sdojjy added a commit to sdojjy/tiflow that referenced this pull request Jan 1, 2024
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request Jan 6, 2024
sdojjy added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants