Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc may request PD too frequently #10168

Closed
hicqu opened this issue Nov 28, 2023 · 0 comments · Fixed by #10170
Closed

cdc may request PD too frequently #10168

hicqu opened this issue Nov 28, 2023 · 0 comments · Fixed by #10170
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.

Comments

@hicqu
Copy link
Contributor

hicqu commented Nov 28, 2023

What did you do?

After tikv/tikv#16054 is introduced, TiCDC may request PD too frequently.
Even if without that PR, TiCDC still may request PD too frequently in some extreme cases.
So it's necessary to limit scan regions concurrency.

What did you expect to see?

No response

What did you see instead?

Scan regions from PD is not limited.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
@hicqu hicqu added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Nov 28, 2023
@hicqu hicqu added severity/minor affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Nov 28, 2023
@hicqu hicqu mentioned this issue Nov 28, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 29, 2023
@hicqu
cdc: fixes minor bugs #10168 and #10169 (#10170)
eb96b96 
close #10168
This was referenced Nov 29, 2023
Merged
Merged
Merged
hicqu added a commit to hicqu/ticdc that referenced this issue Nov 29, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
3bb1955 
Signed-off-by: qupeng <[email protected]>
@hicqu hicqu mentioned this issue Nov 29, 2023
Closed
hicqu added a commit to hicqu/ticdc that referenced this issue Nov 29, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
996ffc4 
Signed-off-by: qupeng <[email protected]>
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Nov 30, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
0a4619b 
Signed-off-by: qupeng <[email protected]>
hicqu added a commit to hicqu/ticdc that referenced this issue Dec 2, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
f8d562c 
Signed-off-by: qupeng <[email protected]>
hicqu added a commit to hicqu/ticdc that referenced this issue Dec 2, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
314c937 
Signed-off-by: qupeng <[email protected]>
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Dec 4, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
f536338 
close pingcap#10168

Signed-off-by: qupeng <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2023
@ti-chi-bot
cdc: fixes minor bugs #10168 and #10169 (#10170) (#10191)
7b2f258 
close #10168
ti-chi-bot bot pushed a commit that referenced this issue Dec 4, 2023
@ti-chi-bot
cdc: fixes minor bugs #10168 and #10169 (#10170) (#10190)
1f6a44b 
close #10168
hicqu added a commit to hicqu/ticdc that referenced this issue Dec 5, 2023
@hicqu
cdc: fixes minor bugs pingcap#10168 and pingcap#10169 (pingcap#10170)
3f6a94c 
close pingcap#10168
hicqu added a commit that referenced this issue Dec 5, 2023
@hicqu
kv-client(cdc): debug frontier (#10253)
d5bf651 
* cdc: fixes minor bugs #10168 and #10169 (#10170)
* puller(cdc): debug frontier (#10202)
* kv-client(cdc): correct conditions of canceling grpc streams  (#10237)

Signed-off-by: qupeng <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@hicqu
cdc: fixes minor bugs #10168 and #10169 (#10170) (#10234)
929d843
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@ti-chi-bot
cdc: fixes minor bugs #10168 and #10169 (#10170) (#10189)
ba6a5c9 
close #10168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cdc: fixes minor bugs #10168 and #10169 hicqu/ticdc
1 participant
@hicqu