tidb_client: improve behavior when no alive tidb instance #900
Conversation
unbyte
changed the title
| f.statusProxy.updateRemotes(nil) | ||
| } | ||
| } else { | ||
| if err == nil { |
There was a problem hiding this comment.
errorx.IsOfType(err, ErrNoAliveTiDB) is a legacy code and is always false, so I simply remove entire err != nil block
|
LGTM. |
| @@ -111,7 +111,10 @@ func (c *Client) OpenSQLConn(user string, pass string) (*gorm.DB, error) { | |||
| if overrideEndpoint != "" { | |||
| addr = overrideEndpoint | |||
| } else { | |||
| addr = fmt.Sprintf("127.0.0.1:%d", c.forwarder.sqlPort) | |||
| var err error | |||
| if addr, err = c.forwarder.getEndpointAddr(c.forwarder.sqlPort); err != nil { | |||
There was a problem hiding this comment.
how about getSQLEndpointAddr?
| @@ -158,10 +164,19 @@ func (c *Client) SendGetRequest(path string) ([]byte, error) { | |||
| if overrideEndpoint != "" { | |||
| addr = overrideEndpoint | |||
| } else { | |||
| addr = fmt.Sprintf("127.0.0.1:%d", c.forwarder.statusPort) | |||
| var err error | |||
| if addr, err = c.forwarder.getEndpointAddr(c.forwarder.statusPort); err != nil { | |||
There was a problem hiding this comment.
how about getStatusEndpointAddr?
| @@ -118,6 +113,14 @@ func (f *Forwarder) pollingForTiDB() { | |||
| } | |||
| } | |||
|
|
|||
| func (f *Forwarder) getEndpointAddr(port int) (string, error) { | |||
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Conflicts: pkg/tidb/client.go
Conflicts: pkg/tidb/client.go
* fix(ttlcache): goroutine leak (#892) * tidb: forwarder only uses tidb whose status is Up (#893) * keyviz: Add tips for enabled config (#901) * ui: rocksdb fields (#896) * monitoring: setup sentry (#895) * tidb_client: improve behavior when no alive tidb instance (#900) * feat(stmt): support config maximum number of stmt kept in memory (#914) * feat: debug api (#898) * ui: Improve settings description for Statement (#920) * feat(ui): add tiflash profiling option (#859) * ui: Add a warning for the debug API (#922)
closes #899