Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ttlcache): goroutine leak #892

Merged
merged 5 commits into from
Apr 20, 2021
Merged

fix(ttlcache): goroutine leak #892

merged 5 commits into from
Apr 20, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Apr 19, 2021 •
edited
Loading

Related: pd/pull/3604

Cleanup ttl cache at end of lifecycle.

@shhdgit
Copy link
Member Author

shhdgit commented Apr 19, 2021 •
edited
Loading

I'm not sure this will solve the problem https://github.com/tikv/pd/pull/3604/checks?check_run_id=2375055816. Maybe we should also add goleak testing.
/cc @breeswish @baurine PTAL.

@shhdgit shhdgit force-pushed the fix/goroutine-leak branch from 92c200b to 5be2bd1 Compare April 19, 2021 01:34
breezewish
breezewish reviewed Apr 20, 2021
View reviewed changes
pkg/utils/sys_schema.go Outdated Show resolved Hide resolved
@shhdgit shhdgit requested a review from breezewish April 20, 2021 03:35
breezewish
breezewish approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec3376b

@ti-chi-bot ti-chi-bot merged commit 8a67f9c into pingcap:master Apr 20, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Apr 29, 2021
@shhdgit
fix(ttlcache): goroutine leak (pingcap#892)
6ec8603
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request May 12, 2021
@shhdgit
fix(ttlcache): goroutine leak (pingcap#892)
283030a
breezewish pushed a commit that referenced this pull request May 12, 2021
@shhdgit
Release v2021.05.12.1 (#921)
4ee3e39 
* fix(ttlcache): goroutine leak (#892)
* tidb: forwarder only uses tidb whose status is Up (#893)
* keyviz: Add tips for enabled config (#901)
* ui: rocksdb fields (#896)
* monitoring: setup sentry (#895)
* tidb_client: improve behavior when no alive tidb instance (#900)
* feat(stmt): support config maximum number of stmt kept in memory (#914)
* feat: debug api (#898)
* ui: Improve settings description for Statement (#920)
* feat(ui): add tiflash profiling option (#859)
* ui: Add a warning for the debug API (#922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shhdgit @ti-chi-bot @breezewish