Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): rocksdb fields in stmt/slowquery copr tab #896

Merged
merged 9 commits into from
Apr 30, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Apr 19, 2021

Show rocksdb fields in Slow Query and Statement detail -> copr tab.

Slow Query:
image

Statement:
image

@shhdgit
Copy link
Member Author

shhdgit commented Apr 19, 2021

/cc @breeswish @baurine PTAL!

ui/lib/utils/callableCache.ts Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/pages/Detail/DetailTabCopr.tsx Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/pages/Detail/DetailTabCopr.tsx Outdated Show resolved Hide resolved
ui/lib/apps/Statement/translations/zh.yaml Outdated Show resolved Hide resolved
@shhdgit shhdgit requested a review from breezewish April 20, 2021 03:35
@shhdgit
Copy link
Member Author

shhdgit commented Apr 20, 2021

In table list:
image
image

In detail list:
image

@shhdgit shhdgit requested a review from breezewish April 20, 2021 08:28
@breezewish breezewish self-assigned this Apr 23, 2021
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

ui/lib/apps/Statement/utils/tableColumns.tsx Outdated Show resolved Hide resolved
ui/lib/apps/Statement/pages/Detail/PlanDetailTabCopr.tsx Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/pages/Detail/DetailTabCopr.tsx Outdated Show resolved Hide resolved
@shhdgit shhdgit requested a review from breezewish April 26, 2021 03:22
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@shhdgit shhdgit requested a review from breezewish April 27, 2021 14:18
ui/lib/apps/Statement/utils/useSchemaColumns.ts Outdated Show resolved Hide resolved
ui/lib/apps/Statement/utils/useSchemaColumns.ts Outdated Show resolved Hide resolved
@shhdgit shhdgit requested a review from breezewish April 28, 2021 11:37
@shhdgit
Copy link
Member Author

shhdgit commented Apr 28, 2021

/cc @baurine
PTAL!

@ti-chi-bot ti-chi-bot requested a review from baurine April 28, 2021 12:59
@breezewish breezewish mentioned this pull request Apr 29, 2021
@breezewish breezewish merged commit ca42293 into pingcap:master Apr 30, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request May 12, 2021
breezewish pushed a commit that referenced this pull request May 12, 2021
* fix(ttlcache): goroutine leak (#892)
* tidb: forwarder only uses tidb whose status is Up (#893)
* keyviz: Add tips for enabled config (#901)
* ui: rocksdb fields (#896)
* monitoring: setup sentry (#895)
* tidb_client: improve behavior when no alive tidb instance (#900)
* feat(stmt): support config maximum number of stmt kept in memory (#914)
* feat: debug api (#898)
* ui: Improve settings description for Statement (#920)
* feat(ui): add tiflash profiling option (#859)
* ui: Add a warning for the debug API (#922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants