Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split packages by features #927

Closed
14 tasks done
php-coder opened this issue Jul 18, 2018 · 12 comments
Closed
14 tasks done

Split packages by features #927

php-coder opened this issue Jul 18, 2018 · 12 comments
Assignees
Labels
impact/changelog This change should be reflected in the NEWS.txt file refactoring
Milestone

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 18, 2018

Let's try to do an experiment by split packages by features. I expect that a package with particular feature will have everything that it is required: controller, service, dao, etc.

Candidates:

  • category
  • country
  • series (depends on category and country features)
  • account
  • collection
  • series import
  • series sales
  • series sales import
  • transaction participant
  • image
  • report
  • mail
  • site
  • common
@php-coder php-coder added this to the next milestone Jul 18, 2018
@php-coder php-coder self-assigned this Jul 18, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
….web.feature.category package.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
…amps.web.feature.category package.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jul 19, 2018
…tamps.web.feature.category package.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
…s.web.feature.country package.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 19, 2018
php-coder added a commit that referenced this issue Jul 20, 2018
…amps.web.feature.country package.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jun 19, 2019
…rresponding class.

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jun 19, 2019
php-coder added a commit that referenced this issue Jun 19, 2019
Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jun 19, 2019
…esourcesAsMap().

Addressed to #927

No functional changes.
php-coder added a commit that referenced this issue Jun 19, 2019
@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Jun 19, 2019
php-coder added a commit that referenced this issue Jun 19, 2019
@php-coder php-coder unpinned this issue Jun 19, 2019
@php-coder
Copy link
Owner Author

A lot of work have been done. While some small issues left, they're related to dependencies between packages rather than split itself. Let's close the issue!

@0pdd
Copy link

0pdd commented Jun 20, 2019

@php-coder 15 puzzles #1037, #1038, #1040, #1041, #1042, #1043, #1044, #1045, #1046, #1047, #1048, #1051, #1052, #1053, #974 are still not solved; solved: #1036, #932.

@0pdd
Copy link

0pdd commented Jun 20, 2019

@php-coder 14 puzzles #1038, #1040, #1041, #1042, #1043, #1044, #1045, #1046, #1047, #1048, #1051, #1052, #1053, #974 are still not solved; solved: #1036, #1037, #932.

@0pdd
Copy link

0pdd commented Jun 20, 2019

@php-coder 13 puzzles #1040, #1041, #1042, #1043, #1044, #1045, #1046, #1047, #1048, #1051, #1052, #1053, #974 are still not solved; solved: #1036, #1037, #1038, #932.

@0pdd
Copy link

0pdd commented Oct 8, 2019

@php-coder 12 puzzles #1040, #1041, #1042, #1043, #1044, #1045, #1046, #1047, #1048, #1051, #1053, #974 are still not solved; solved: #1036, #1037, #1038, #1052, #932.

@0pdd
Copy link

0pdd commented Oct 8, 2019

@php-coder 11 puzzles #1040, #1041, #1042, #1043, #1044, #1045, #1046, #1047, #1048, #1051, #974 are still not solved; solved: #1036, #1037, #1038, #1052, #1053, #932.

@php-coder php-coder mentioned this issue Apr 15, 2020
10 tasks
php-coder added a commit that referenced this issue Feb 13, 2021
… appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 13, 2021
…ies to the appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 13, 2021
…propriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 14, 2021
…ropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 14, 2021
…appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 14, 2021
…priate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 14, 2021
…s to the appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 14, 2021
…s to the appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 15, 2021
…e appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 16, 2021
…opriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 16, 2021
…erties to the appropriate package config

We also switched to using Environment.getRequiredProperty() because @value doesn't work
without PropertySourcesPlaceholderConfigurer bean (that we are going to remove soon).

Relate to #927
php-coder added a commit that referenced this issue Feb 16, 2021
…ies file and use it

Correction for 5d486a3 or 59c9c83
commits.

Relate to #927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/changelog This change should be reflected in the NEWS.txt file refactoring
Projects
None yet
Development

No branches or pull requests

2 participants