Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PurchaseAndSaleDto: move with related classes to series.sale package #1051

Closed
0pdd opened this issue Jun 16, 2019 · 1 comment
Closed

PurchaseAndSaleDto: move with related classes to series.sale package #1051

0pdd opened this issue Jun 16, 2019 · 1 comment
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4.4

Comments

@0pdd
Copy link

0pdd commented Jun 16, 2019 •
edited by php-coder
Loading

The puzzle 927-0d92cb6b from #927 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/PurchaseAndSaleDto.java

Line 27 in 6fc61a2

// @todo #927 PurchaseAndSaleDto: move with related classes to series.sale package

The puzzle was created by Slava Semushin on 16-Jun-19.
@0pdd 0pdd added the techdebt label Jun 16, 2019
0pdd referenced this issue Jun 16, 2019
@php-coder
chore: add TODO items for the next refactoring steps.
6fc61a2 
Addressed to #927

[skip ci]
@0pdd 0pdd mentioned this issue Jun 16, 2019
Closed
14 tasks
@php-coder php-coder added this to the 0.4.2 milestone Sep 9, 2019
@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder php-coder self-assigned this Apr 13, 2020
@php-coder php-coder modified the milestones: next, 0.4.4 Apr 13, 2020
php-coder added a commit that referenced this issue Jun 9, 2020
@php-coder
refactor: move a query for series_sales table to appropriate properti…
8487a12 
…es file.

Part of #1051
php-coder added a commit that referenced this issue Jun 9, 2020
@php-coder
refactor: move dao/service/mapper methods that work with PurchaseAndS…
07ff2c7 
…aleDto to ru.mystamps.web.feature.series.sale package.

Part of #1051
php-coder added a commit that referenced this issue Jun 9, 2020
@php-coder
refactor: rename purchasesAndSales to seriesSales.
581cd82 
Part of #1051
php-coder added a commit that referenced this issue Jun 9, 2020
@php-coder
refactor: move and rename PurchaseAndSaleDto to ru.mystamps.web.featu…
1ec7639 
…re.series.sale package.

Part of #1051
@0pdd 0pdd closed this as completed Jun 9, 2020
@0pdd
Copy link
Author

0pdd commented Jun 9, 2020

The puzzle 927-0d92cb6b has disappeared from the source code, that's why I closed this issue.

0pdd referenced this issue Jun 9, 2020
@php-coder
fix(series import): fix incorrect quantity extraction when a fragment…
add39cc 
… doesn't contain "stamps" word.

Part of #1376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd