Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeriesService.countSeriesOf(): move to CollectionService #932

Closed
0pdd opened this issue Jul 26, 2018 · 0 comments
Closed

SeriesService.countSeriesOf(): move to CollectionService #932

0pdd opened this issue Jul 26, 2018 · 0 comments
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Jul 26, 2018 •
edited by php-coder
Loading

The puzzle 927-e88d3d70 from #927 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/SeriesService.java

Line 38 in ba083d8

// @todo #927 SeriesService.countSeriesOf(): move to CollectionService

The puzzle was created by Slava Semushin on 24-Jul-18.
@0pdd 0pdd added the techdebt label Jul 26, 2018
0pdd referenced this issue Jul 26, 2018
@php-coder
CollectionController: move to ru.mystamps.web.feature.collection pack…
ba083d8 
…age.

Addressed to #927

No functional changes.
@0pdd 0pdd mentioned this issue Jul 26, 2018
Closed
14 tasks
@php-coder php-coder self-assigned this Sep 11, 2018
@php-coder php-coder added this to the 0.4 milestone Sep 11, 2018
0pdd referenced this issue Sep 11, 2018
@php-coder
fix: update supression filter to also ignore complains about field.
c61dedc 
The error was:
[INFO] new ru.mystamps.web.feature.image.DbImageDto(String, byte[]) may expose internal
representation by storing an externally mutable object into DbImageDto.data
[ru.mystamps.web.feature.image.DbImageDto] At DbImageDto.java:[line 26] EI_EXPOSE_REP2

Correction for 0ba80d2 commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd