Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Test: Greenhouse Effect 1.1.0-rc.1 #871

Closed
3 of 4 tasks
jbphet opened this issue Dec 22, 2022 · 9 comments
Closed
3 of 4 tasks

Prototype Test: Greenhouse Effect 1.1.0-rc.1 #871

jbphet opened this issue Dec 22, 2022 · 9 comments
Assignees
Labels
QA:prototype-test For testing prototype sims

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 22, 2022

Prototype Test

Mentions: @arouinfar, @kathy-phet, @KatieWoe, and @jessegreenberg

Simulation links

Test Matricies

Features included

  • Alternative Input
  • UI Sound
  • Sonification
  • Description (first screen only)

Focus and Special Instructions

This prototype adds two new screens that did not exist in the previous prototype, namely the "Photons" and "Layer
Model" screens. The focus of this testing should be to verify that these two screens appear to behave correctly
and do not have any major behavioral issues. The first screen has had some changes made to it as well, so it should
be regression tested.

In addition to the new screens, the following features have been added and should be tested:

  • Sound design.
  • Dynamic locales and layouts.
  • The artwork has been updated, so please look for anything that is problematic in that area.
  • The focus order has been updated, so please verify that it is reasonable.

Description was implemented for the first screen in the previous prototype, but has not been completed for the second
nor the third, so please regression test it on the first screen and make sure that there isn't anything egregiously wrong
with it on the second and third screens, but gaps and omissions are expected on those screens.

Edit: Screen reader testing will not be a part of this QA cycle, see #871 (comment).

Issues to Verify

We've been doing verification of issues internally between the development and design teams, so there isn't anything to
list in this section for this round of testing.


For QA...

General features

What to Test

  • Play with the simulation normally.
  • Make sure you can't lose anything.
  • Complete the test matrix.
  • Try to include version numbers for browsers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Focus on pedagogy issues and bugs that break the sim.
  • If you find bugs beyond pedagogy/breaking, still document these bugs as github issues.
  • If a11y aspects are present, test them, but with an eye for "normal use".

Accessibility features

What to Test

If a11y aspects are present, test them, but with an eye for "normal use".

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).
  • If this sim is not in this list or up to date there, make an
    issue in website to ask if PhET research page links need updating. Please
    assign to @terracoda and @emily-phet.

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@jbphet jbphet added the QA:prototype-test For testing prototype sims label Dec 22, 2022
@KatieWoe
Copy link
Contributor

Memory Test:
greenmem

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 6, 2023

phetsims/ratio-and-proportion#542 is an issue in this sim as well. Should I make a sim specific issue for it?

@jessegreenberg
Copy link
Contributor

phetsims/ratio-and-proportion#542 Added alternative input support for sliders when using a number pad. It didn't seem important enough to me to maintenance release RCs or published sims, but I think it is a call for @kathy-phet or @arouinfar.

@arouinfar
Copy link
Contributor

Description was implemented for the first screen in the previous prototype, but has not been completed for the second
nor the third, so please regression test it on the first screen and make sure that there isn't anything egregiously wrong
with it on the second and third screens, but gaps and omissions are expected on those screens.

@jbphet the previous prototype does not support alt input or description. It looks like @Nancy-Salpepi discovered a possible regression in phetsims/greenhouse-effect#254, but in general, I'm not sure how much time or effort we should put into testing screen reader behavior for the prototype. We agreed to leave supportsInteractiveDescription: true but not advertise the feature.

@arouinfar
Copy link
Contributor

in general, I'm not sure how much time or effort we should put into testing screen reader behavior for the prototype.

Discussed with @jbphet and we decided to proceed with screen reader testing as originally requested. We are unlikely to fix screen reader bugs for the prototype since we aren't advertising the feature. However, it's still important to know about the existing bugs.

@arouinfar
Copy link
Contributor

@kathy-phet said:

Given the backlog in QA, I think we should forgo the screenreader testing ... this adds a lot to a test and we need to focus on moving things through that are important for the release. We can put it back in for a screen reader only focused test when there is more bandwidth for QA - before we pick GHE description up again.

@Nancy-Salpepi has let the QA channel know about this change, and I will update the test issue.

@KatieWoe
Copy link
Contributor

KatieWoe commented Jan 9, 2023

Calling QA here

@KatieWoe KatieWoe assigned jbphet and unassigned KatieWoe Jan 9, 2023
@stemilymill
Copy link
Contributor

While testing on chromebook, I noticed some jerky animation due to low-performance device. Did not impact usability, but seemed like it should be mentioned.

here is a video https://photos.google.com/search/_tra_/photo/AF1QipO959Ux95b9MvWKr2Os_Nzeb0F7QT7D3VTkWR3i

sorry the video is not embedded here, I dont know why github isn't letting me add it

samreid added a commit to phetsims/phet-info that referenced this issue Jan 10, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Jan 17, 2023

Thanks QA team. I'll follow up on the individual issues noted above. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:prototype-test For testing prototype sims
Projects
Status: Done
Development

No branches or pull requests

6 participants