-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing Controls section in dialog doesn't change in string tests #257
Comments
@arouinfar - This is a common code issue, and I need to work with @jessegreenberg to potentially fix it. I'm assuming that I should wait to hear from him before proceeding with the next prototype RC, please let me know if you disagree. |
OK, commit to make these translatable done above. |
Thanks @jessegreenberg! Let's incorporate these changes into the prototype @jbphet. |
I've incorporated the changes into the 1.1 release branch. |
Looks good in rc.2. |
Test device
Dell and Mac
Operating System
Win10/macOS 13.1
Browser
FireFox and chrome
Problem description
For phetsims/qa#871, for all string tests, the Timing Controls title and "pause or play action" in Keyboard Shortcuts dialog don't change.
Visuals
The text was updated successfully, but these errors were encountered: