Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing Controls section in dialog doesn't change in string tests #257

Closed
Tracked by #885
Nancy-Salpepi opened this issue Jan 9, 2023 · 5 comments
Closed
Tracked by #885

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jan 9, 2023

Test device
Dell and Mac

Operating System
Win10/macOS 13.1

Browser
FireFox and chrome

Problem description
For phetsims/qa#871, for all string tests, the Timing Controls title and "pause or play action" in Keyboard Shortcuts dialog don't change.

Visuals

Screenshot 2023-01-09 at 9 00 06 AM

Screenshot 2023-01-09 at 9 01 50 AM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Greenhouse Effect‬:‪Greenhouse Effect‬ URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html?stringTest=double Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 Language: en-US Window: 1475x780 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@jbphet
Copy link
Contributor

jbphet commented Jan 13, 2023

@arouinfar - This is a common code issue, and I need to work with @jessegreenberg to potentially fix it. I'm assuming that I should wait to hear from him before proceeding with the next prototype RC, please let me know if you disagree.

@jessegreenberg
Copy link
Contributor

OK, commit to make these translatable done above.

@arouinfar
Copy link
Contributor

Thanks @jessegreenberg! Let's incorporate these changes into the prototype @jbphet.

@arouinfar arouinfar removed their assignment Jan 14, 2023
jbphet pushed a commit to phetsims/scenery-phet that referenced this issue Jan 17, 2023
@jbphet
Copy link
Contributor

jbphet commented Jan 17, 2023

I've incorporated the changes into the 1.1 release branch.

@Nancy-Salpepi
Copy link
Author

Looks good in rc.2.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants