Flux Meter stroke extends past dark overlay before sunlight starts

[marlitas]

Test device
Mac

Operating System
OS 13.01

Browser
Chrome

Problem description
phetsims/qa#871
Flux Meter orange stroke extends past dark overlay before sunlight has started.

Steps to reproduce

1. Open Layer Model screen
2. Turn on flux meter
3. Drag all the way up

Visuals

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Greenhouse Effect‬
URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html?
Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36
Language: en-US
Window: 1920x944
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

[jbphet]

This was happening because of the stroke on the edges of the observation window - the darkness node was inside that window, but the edges of the flux sensor could go above the stroke. I've removed the stroke, which looks better all around, and made some layout adjustments as well. This addresses the basic issue. I've also adjust the vertical range of the flux sensor so that it stays completely within the window.

[Nancy-Salpepi]

This looks fixed in rc.2. Closing

[Nancy-Salpepi]

Noticed that the interactive highlight for the flux meter extends past the observation window. Is that OK?

[arouinfar]

Thanks for checking @Nancy-Salpepi. The probe moves behind the Energy Balance panel, but focus/interactive highlights are always layered on top, which creates situations like this:

I think the Z-order of the probe is correct. It should not interfere with reading the Energy Balance data, so it goes behind the panel. However, the probe is rather large so most of it remains unobscured. This looks a little weird when it has focus, but I think that's okay.