Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grunt.log.debug does not exist in @types #1540

Closed
samreid opened this issue Dec 3, 2024 · 3 comments
Closed

grunt.log.debug does not exist in @types #1540

samreid opened this issue Dec 3, 2024 · 3 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Dec 3, 2024

From #1465. So we have 13 calls to grunt.log.debug, and each has a ts-expect-error. We could try to add to DefinitelyTyped, or stop calling grunt.log.debug, or maybe do interface extension.
@samreid samreid self-assigned this Dec 3, 2024
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1465 and #1540
5d356b3
@samreid
Copy link
Member Author

samreid commented Dec 3, 2024

Since we would like to move away from grunt in #1436, let's just use grunt.log.verbose.writeln instead.

samreid added a commit to phetsims/perennial that referenced this issue Dec 3, 2024
@samreid
Use grunt.log.verbose.writeln instead of grunt.log.debug, see phetsim…
ae7465f 
…s/chipper#1540
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Use grunt.log.verbose.writeln instead of grunt.log.debug, see #1540
ddfac48
@samreid
Copy link
Member Author

samreid commented Dec 3, 2024 •
edited
Loading

Fixed in the commits, @zepumph want to spot check? Should we notify everyone to use --verbose instead of --debug?

@samreid samreid removed their assignment Dec 3, 2024
@zepumph
Copy link
Member

zepumph commented Dec 3, 2024

I love this. I made a private note for dev PSA. Thanks for doing this.

@zepumph zepumph closed this as completed Dec 3, 2024
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
@samreid @jessegreenberg
Use grunt.log.verbose.writeln instead of grunt.log.debug, see phetsim…
2d5d815 
…s/chipper#1540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph