Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert repo to TypeScript #1465

Closed
zepumph opened this issue Sep 19, 2024 · 2 comments
Closed

Convert repo to TypeScript #1465

zepumph opened this issue Sep 19, 2024 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Sep 19, 2024

From #1464, this issue is just to hold commits where we convert files to typescript.
zepumph added a commit that referenced this issue Sep 19, 2024
@zepumph
path problem, #1465
937f820 
Signed-off-by: Michael Kauzmann <[email protected]>
zepumph added a commit that referenced this issue Sep 19, 2024
@zepumph
remove some ts-expect-errors, #1465
6ec7ef1 
Signed-off-by: Michael Kauzmann <[email protected]>
@zepumph zepumph mentioned this issue Sep 19, 2024
Closed
7 tasks
samreid added a commit that referenced this issue Oct 9, 2024
@samreid
Move TODO to issue, see #1479 and #1459 and #1465
0eae7e9
@samreid samreid self-assigned this Oct 14, 2024
samreid added a commit that referenced this issue Oct 14, 2024
@samreid
Convert to import statements, see #1465
86e0387
samreid added a commit that referenced this issue Oct 14, 2024
@samreid
Fix imports, see #1465
8a87b7e
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
1a2a449
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
5fdb3d1
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
eddb714
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
5f520c3
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
d14c1df
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
1aa1766
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
d64b117
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
7eae15d
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
8d66d6f
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
d49f9e2
samreid added a commit to phetsims/perennial that referenced this issue Oct 15, 2024
@samreid
Remove unused file, see phetsims/chipper#1465
60f99a5
samreid added a commit to phetsims/perennial that referenced this issue Oct 15, 2024
@samreid
Remove unused file, see phetsims/chipper#1465
f322df2
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Remove unused file, see #1465
f3b10f9
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
a397dc0
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
4011d3d
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
4fb3dbe
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
77ca0ec
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
f256ebe
samreid added a commit that referenced this issue Oct 15, 2024
@samreid
Convert to TypeScript, see #1465
d584942
@samreid samreid removed their assignment Oct 16, 2024
zepumph added a commit to phetsims/aqua that referenced this issue Oct 23, 2024
@zepumph
rename to typescript, phetsims/chipper#1465
40cee71
zepumph added a commit to phetsims/aqua that referenced this issue Oct 23, 2024
@zepumph
convert to typescript, phetsims/chipper#1465
e47a2bc
@samreid samreid self-assigned this Oct 24, 2024
@samreid samreid self-assigned this Nov 27, 2024
samreid added a commit to phetsims/aqua that referenced this issue Dec 2, 2024
@samreid
Allow phet-core/types in aqua, see phetsims/chipper#1465
997dda3
samreid added a commit to phetsims/aqua that referenced this issue Dec 2, 2024
@samreid
Improve options type, see phetsims/chipper#1465
2dfddb7
samreid added a commit that referenced this issue Dec 2, 2024
@samreid
Use affirm, see #1465
7d7c8f5
samreid added a commit to phetsims/perennial that referenced this issue Dec 2, 2024
@samreid
Update documentation, see phetsims/chipper#1465
f3e9040
samreid added a commit that referenced this issue Dec 2, 2024
@samreid
Use affirm, see #1465
b5a53a7
@samreid samreid mentioned this issue Dec 3, 2024
Open
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1537 and #1465
2c8dcbd
@samreid samreid mentioned this issue Dec 3, 2024
Open
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1538 and #1465
68c5684
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1537 and #1465
edf9504
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Improve MinifyOptions, see #1465
16ca0da
@samreid samreid mentioned this issue Dec 3, 2024
Open
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1465 and #1539
f2e6458
@samreid samreid mentioned this issue Dec 3, 2024
Closed
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Move TODO, see #1465 and #1540
5d356b3
samreid added a commit that referenced this issue Dec 3, 2024
@samreid
Use IntentionalAny in chipper, see #1465
12daedc
samreid added a commit to phetsims/perennial that referenced this issue Dec 3, 2024
@samreid
Update documentation, see phetsims/chipper#1465
54e6bd2
@samreid
Copy link
Member

samreid commented Dec 3, 2024

All issues addressed or moved elsewhere, @zepumph want to spot check or work on anything else as part of this issue? If not, feel free to close.

@samreid samreid assigned zepumph and unassigned samreid Dec 3, 2024
@zepumph
Copy link
Member Author

zepumph commented Dec 3, 2024

I looked through usages of ts-expect-error and IntentionalAny. The main work left is in side issues with the exception of using optionize. I add that over to #1523.

@zepumph zepumph closed this as completed Dec 3, 2024
zepumph added a commit that referenced this issue Dec 3, 2024
@zepumph
remove ts-expect-errors, #1465
c74013d
zepumph added a commit that referenced this issue Dec 3, 2024
@zepumph
remove IntentionalAny usages, #1465
d102cdd
zepumph added a commit that referenced this issue Dec 3, 2024
@zepumph
remove IntentionalAny usages, and assert && in node, #1465
68da07b
@zepumph zepumph mentioned this issue Dec 3, 2024
Open
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
@samreid @jessegreenberg
Update documentation, see phetsims/chipper#1465
075ad5a
jessegreenberg pushed a commit to phetsims/perennial that referenced this issue Dec 10, 2024
@samreid @jessegreenberg
Update documentation, see phetsims/chipper#1465
a387533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph