Skip to content

Commit

Permalink
Move TODO, see #1465 and #1540
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Dec 3, 2024
1 parent f2e6458 commit 5d356b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/grunt/buildRunnable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ export default async function( repo: string, minifyOptions: MinifyOptions, allHT
if ( _.includes( locales, ChipperConstants.FALLBACK_LOCALE ) && brand === 'phet' ) {
const englishTitle = stringMap[ ChipperConstants.FALLBACK_LOCALE ][ getTitleStringKey( repo ) ];

// TODO: maybe we need to commit a change to DefinitelyTyped to support debug logging https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/grunt/index.d.ts#L725, https://github.com/phetsims/chipper/issues/1465
// TODO: maybe we need to commit a change to DefinitelyTyped to support debug logging https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/grunt/index.d.ts#L725, https://github.com/phetsims/chipper/issues/1540
// @ts-expect-error debug is unknown in the type
grunt.log.debug( 'Constructing HTML for iframe testing from template' );
let iframeTestHtml = grunt.file.read( '../chipper/templates/sim-iframe.html' );
Expand Down

0 comments on commit 5d356b3

Please sign in to comment.